Crash in Decode.cpp

[tlbradshaw]

I'm running this code on a PI3 using an Oregon rain sensor, and an outdoor temperature monitor. I know the data being received isn't always the cleanest (sometime too short, sometimes letters in the data packet). I've added validation to fix most of this, but I keep getting random fatal errors during the call to "read433". Since the error occurs in the CPP code, I'm not getting anything in the log file. The python thread just crashes. Any idea how to log this error, or provide some more robustness in decode.cpp or the other CPP classes?

[jaycedowell]

When I run into problems with Python extensions I usually insert printf() calls throughout the extension to try and pin down where the problems are occurring. These should end up logged to the /tmp/wxPi.stdout file. You might also check to see if there is anything currently in this file or /tmp/wxPi.stderr that might indicate an uncaught exception.

[tlbradshaw]

Thanks for the reply. That's basically what I'm doing except I'm using the logger. The problem is, I can watch it go into the c++ code, but I can seem to log any errors from there. It's a random issue that only happens about every 20 - 30 minutes, but it causes a fatal crash. Thanks for the response, and thanks for the great code!

…

On Aug 4, 2017 8:50 AM, "jaycedowell" ***@***.***> wrote: When I run into problems with Python extensions I usually insert printf() calls throughout the extension to try and pin down where the problems are occurring. These should end up logged to the /tmp/wxPi.stdout file. You might also check to see if there is anything currently in this file or /tmp/wxPi.stderr that might indicate an uncaught exception. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARJyGa5T2LmtB9UQX0086ve8-IezPMH9ks5sUyGdgaJpZM4OslPn> .

[jaycedowell]

Hrm, I'll give it some more thought.

[jaycedowell]

It might help to run wxPi.py without daemonization. To turn it off, comment out line 381 in wxPy.pi. After that, you might also set verbose = 1 on line 31 of decoder.cpp and recompile. After making the changes you'll need to manually launch the script and keep it running your terminal session. It could be that there is a particular message that is triggering the crash.

[tlbradshaw]

I think I'm getting pretty close. I've added this to the decode.cpp file. I was getting some empty messages being decoded, but they must have had some non printed characters that was causing the code to fail. if( strlen(message) < 10 ) { cout << "Empty message" << "\n" << flush; continue; } strcpy(messages[nMessage], message); nMessage += 1; The next problem I ran into was into was that sometimes the data packet would return with mostly letters which would cause the parser.py to fail trying to get the temperature. I've added try catch blocks and now I think it's pretty stable. Thanks for all you help! On Aug 13, 2017 1:26 PM, "jaycedowell" <notifications@github.com> wrote: It might help to run wxPi.py without daemonization. To turn it off, comment out line 381 in wxPy.pi. After that, you might also set verbose = 1 on line 31 of decoder.cpp and recompile. After making the changes you'll need to manually launch the script and keep it running your terminal session. It could be that there is a particular message that is triggering the crash. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARJyGQgys0aKjsH6GS2NXJENRk08OImjks5sXz_mgaJpZM4OslPn> .

[jaycedowell]

Cool, I'm glad to hear that. Would you mind submitting a pull request for your changes so that I can add them to the main repository?