Merge pull request #4 from 123Haynes/remove_deprecated_api

Remove old Gitlab V3 API

Author: javamachr

README.md

@@ -345,7 +345,7 @@ https://docs.gitlab.com/ce/ci/variables/#9-0-renaming
 | sonar.gitlab.ping_user | Ping the user who made an issue by @ mentioning. Only for default comment (default false) | Administration, Variable | >= 2.0.0 |
 | sonar.gitlab.unique_issue_per_inline | Unique issue per inline comment (default false) | Administration, Variable | >= 2.0.0 |
 | sonar.gitlab.prefix_directory | Add prefix when create link for GitLab | Variable | >= 2.1.0 |
-| sonar.gitlab.api_version | GitLab API version (default `v4` or `v3`) | Administration, Variable | >= 2.1.0 |
+| sonar.gitlab.api_version | GitLab API version (default `v4`) | Administration, Variable | >= 2.1.0 |
 | sonar.gitlab.all_issues | All issues new and old (default false, only new) | Administration, Variable | >= 2.1.0 |
 | sonar.gitlab.json_mode | Create a json report in root for GitLab EE (codeclimate.json or gl-sast-report.json) | Project, Variable | >= 3.0.0 |
 | sonar.gitlab.query_max_retry | Max retry for wait finish analyse for publish mode | Administration, Variable | >= 3.0.0 |

src/main/java/com/talanlabs/sonar/plugins/gitlab/CommitFacade.java

@@ -59,9 +59,7 @@ public CommitFacade(GitLabPluginConfiguration gitLabPluginConfiguration) {
 
         this.ruleUrlPrefix = gitLabPluginConfiguration.baseUrl();
 
-        if (GitLabPlugin.V3_API_VERSION.equals(gitLabPluginConfiguration.apiVersion())) {
-            this.gitLabWrapper = new GitLabApiV3Wrapper(gitLabPluginConfiguration);
-        } else if (GitLabPlugin.V4_API_VERSION.equals(gitLabPluginConfiguration.apiVersion())) {
+        if (GitLabPlugin.V4_API_VERSION.equals(gitLabPluginConfiguration.apiVersion())) {
             this.gitLabWrapper = new GitLabApiV4Wrapper(gitLabPluginConfiguration);
         }
     }

src/main/java/com/talanlabs/sonar/plugins/gitlab/GitLabApiV3Wrapper.java

@@ -72,7 +72,6 @@ public class GitLabPlugin implements Plugin {
     public static final String CATEGORY = "gitlab";
     public static final String SUBCATEGORY = "reporting";
 
-    public static final String V3_API_VERSION = "v3";
     public static final String V4_API_VERSION = "v4";
 
     public static List<PropertyDefinition> definitions() {
@@ -133,7 +132,7 @@ public static List<PropertyDefinition> definitions() {
                         PropertyDefinition.builder(GITLAB_PREFIX_DIRECTORY).name("Prefix directory for GitLab link").description("Add prefix for GitLab link").category(CATEGORY).subCategory(SUBCATEGORY)
                                 .type(PropertyType.STRING).defaultValue("").index(24).build(),
                         PropertyDefinition.builder(GITLAB_API_VERSION).name("Set GitLab API version").description("GitLab API version").category(CATEGORY).subCategory(SUBCATEGORY)
-                                .type(PropertyType.SINGLE_SELECT_LIST).options(V3_API_VERSION, V4_API_VERSION).defaultValue(V4_API_VERSION).index(25).build(),
+                                .type(PropertyType.SINGLE_SELECT_LIST).options(V4_API_VERSION).defaultValue(V4_API_VERSION).index(25).build(),
                         PropertyDefinition.builder(GITLAB_ALL_ISSUES).name("All issues").description("Show all issues. (Default false, only new)").category(CATEGORY).subCategory(SUBCATEGORY)
                                 .type(PropertyType.BOOLEAN).defaultValue(String.valueOf(false)).index(26).build(),
                         PropertyDefinition.builder(GITLAB_JSON_MODE).name("Generate json report").description("Create a json report in root for GitLab EE").category(CATEGORY).subCategory(SUBCATEGORY)