Skip to content
This repository was archived by the owner on May 28, 2018. It is now read-only.

Commit 0062bdf

Browse files
Petr BoudaGerrit Code Review
authored andcommitted
Merge "Replaces HK2 InjectionResolver by Jersey InjectionResolver for an injection of PersistenceUnit."
2 parents a9dbd22 + df985f0 commit 0062bdf

File tree

2 files changed

+23
-16
lines changed

2 files changed

+23
-16
lines changed

containers/jersey-servlet-core/src/main/java/org/glassfish/jersey/servlet/WebComponent.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ public ServletConfig provide() {
250250
final String initParamName = (String) initParams.nextElement();
251251

252252
if (initParamName.startsWith(PersistenceUnitBinder.PERSISTENCE_UNIT_PREFIX)) {
253-
install(new PersistenceUnitBinder());
253+
install(new PersistenceUnitBinder(servletConfig));
254254
break;
255255
}
256256
}

containers/jersey-servlet-core/src/main/java/org/glassfish/jersey/servlet/internal/PersistenceUnitBinder.java

Lines changed: 22 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -47,42 +47,45 @@
4747

4848
import javax.ws.rs.core.GenericType;
4949

50-
import javax.inject.Inject;
5150
import javax.inject.Singleton;
5251
import javax.persistence.EntityManagerFactory;
5352
import javax.persistence.PersistenceUnit;
5453
import javax.servlet.ServletConfig;
5554

5655
import org.glassfish.jersey.internal.inject.AbstractBinder;
57-
import org.glassfish.jersey.internal.inject.InjectionManager;
56+
import org.glassfish.jersey.internal.inject.Injectee;
57+
import org.glassfish.jersey.internal.inject.InjectionResolver;
5858
import org.glassfish.jersey.server.ContainerException;
5959

60-
import org.glassfish.hk2.api.Injectee;
61-
import org.glassfish.hk2.api.InjectionResolver;
62-
import org.glassfish.hk2.api.ServiceHandle;
63-
6460
/**
6561
* {@link PersistenceUnit Persistence unit} injection binder.
6662
*
6763
* @author Michal Gajdos
6864
*/
6965
public class PersistenceUnitBinder extends AbstractBinder {
7066

67+
private final ServletConfig servletConfig;
68+
7169
/**
7270
* Prefix of the persistence unit init param.
7371
*/
7472
public static final String PERSISTENCE_UNIT_PREFIX = "unit:";
7573

74+
/**
75+
* Creates a new binder for {@link PersistenceUnitInjectionResolver}.
76+
*
77+
* @param servletConfig servlet config to find persistence units.
78+
*/
79+
public PersistenceUnitBinder(ServletConfig servletConfig) {
80+
this.servletConfig = servletConfig;
81+
}
82+
7683
@Singleton
7784
private static class PersistenceUnitInjectionResolver implements InjectionResolver<PersistenceUnit> {
7885

7986
private final Map<String, String> persistenceUnits = new HashMap<>();
8087

81-
@Inject
82-
private PersistenceUnitInjectionResolver(final InjectionManager injectionManager) {
83-
// Look for persistence units.
84-
final ServletConfig servletConfig = injectionManager.getInstance(ServletConfig.class);
85-
88+
private PersistenceUnitInjectionResolver(ServletConfig servletConfig) {
8689
for (final Enumeration parameterNames = servletConfig.getInitParameterNames(); parameterNames.hasMoreElements(); ) {
8790
final String key = (String) parameterNames.nextElement();
8891

@@ -94,7 +97,7 @@ private PersistenceUnitInjectionResolver(final InjectionManager injectionManager
9497
}
9598

9699
@Override
97-
public Object resolve(final Injectee injectee, final ServiceHandle<?> root) {
100+
public Object resolve(Injectee injectee) {
98101
if (!injectee.getRequiredType().equals(EntityManagerFactory.class)) {
99102
return null;
100103
}
@@ -121,12 +124,16 @@ public boolean isConstructorParameterIndicator() {
121124
public boolean isMethodParameterIndicator() {
122125
return false;
123126
}
127+
128+
@Override
129+
public Class<PersistenceUnit> getAnnotation() {
130+
return PersistenceUnit.class;
131+
}
124132
}
125133

126134
@Override
127135
protected void configure() {
128-
bind(PersistenceUnitInjectionResolver.class)
129-
.to(new GenericType<InjectionResolver<PersistenceUnit>>() {})
130-
.in(Singleton.class);
136+
bind(new PersistenceUnitInjectionResolver(servletConfig))
137+
.to(new GenericType<InjectionResolver<PersistenceUnit>>() {});
131138
}
132139
}

0 commit comments

Comments
 (0)