chore: adds null check to CacheUpdater

Author: NightTripperID

api/src/main/java/com/javadiscord/jdi/core/api/DiscordResponseParser.java

@@ -3,9 +3,7 @@
 import java.util.List;
 import java.util.Map;
 
-import com.fasterxml.jackson.core.JsonProcessingException;
-import com.fasterxml.jackson.databind.ObjectMapper;
-import com.javadiscord.jdi.core.api.utils.CacheUpdateHandler;
+import com.javadiscord.jdi.core.api.utils.CacheUpdater;
 import com.javadiscord.jdi.internal.api.DiscordRequest;
 import com.javadiscord.jdi.internal.api.DiscordRequestDispatcher;
 import com.javadiscord.jdi.internal.api.DiscordResponse;
@@ -18,11 +16,11 @@
 public class DiscordResponseParser {
     private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
     private final DiscordRequestDispatcher dispatcher;
-    private final CacheUpdateHandler cacheUpdateHandler;
+    private final CacheUpdater cacheUpdater;
 
     public DiscordResponseParser(DiscordRequestDispatcher dispatcher, Cache cache) {
         this.dispatcher = dispatcher;
-        this.cacheUpdateHandler = new CacheUpdateHandler(cache);
+        this.cacheUpdater = new CacheUpdater(cache);
     }
 
     public <T> AsyncResponse<List<T>> callAndParseList(Class<T> clazz, DiscordRequest request) {
@@ -34,6 +32,7 @@ public <T> AsyncResponse<List<T>> callAndParseList(Class<T> clazz, DiscordReques
                     try {
                         List<T> resultList = parseResponseFromList(clazz, response.body());
                         asyncResponse.setResult(resultList);
+                        cacheUpdater.updateCache(resultList);
                     } catch (Exception e) {
                         asyncResponse.setException(e);
                     }
@@ -42,19 +41,6 @@ public <T> AsyncResponse<List<T>> callAndParseList(Class<T> clazz, DiscordReques
                 }
             }
         );
-                response -> {
-                    if (isSuccessfulResponse(response)) {
-                        try {
-                            List<T> resultList = parseResponseFromList(clazz, response.body());
-                            asyncResponse.setResult(resultList);
-                            cacheUpdateHandler.updateCache(resultList);
-                        } catch (Exception e) {
-                            asyncResponse.setException(e);
-                        }
-                    } else {
-                        asyncResponse.setException(errorResponseException(response));
-                    }
-                });
         future.onError(asyncResponse::setException);
         return asyncResponse;
     }
@@ -76,19 +62,6 @@ public <T> AsyncResponse<List<T>> callAndParseMap(String key, DiscordRequest req
                 }
             }
         );
-                response -> {
-                    if (isSuccessfulResponse(response)) {
-                        try {
-                            List<T> resultList = parseResponseFromMap(key, response.body());
-                            asyncResponse.setResult(resultList);
-                            cacheUpdateHandler.updateCache(resultList);
-                        } catch (Exception e){
-                            asyncResponse.setException(e);
-                        }
-                    } else {
-                        asyncResponse.setException(errorResponseException(response));
-                    }
-                });
         future.onError(asyncResponse::setException);
         return asyncResponse;
     }
@@ -137,7 +110,7 @@ private <T> void success(
                     result = OBJECT_MAPPER.readValue(response.body(), type);
                 }
                 asyncResponse.setResult(result);
-                cacheUpdateHandler.updateCache(result);
+                cacheUpdater.updateCache(result);
             } catch (JsonProcessingException e) {
                 asyncResponse.setException(e);
             }

api/src/main/java/com/javadiscord/jdi/core/api/utils/CacheUpdateHandler.java renamed to api/src/main/java/com/javadiscord/jdi/core/api/utils/CacheUpdater.java

@@ -5,15 +5,18 @@
 import java.lang.reflect.Field;
 import java.util.List;
 
-public class CacheUpdateHandler {
+public class CacheUpdater {
 
     private final Cache cache;
 
-    public CacheUpdateHandler(Cache cache) {
+    public CacheUpdater(Cache cache) {
         this.cache = cache;
     }
 
     public <T> void updateCache(T result) {
+        if (result == null) {
+            return;
+        }
         try {
             Field guildIdField = result.getClass().getDeclaredField("guildId");
             Field idField = result.getClass().getDeclaredField("id");