Skip to content

Commit 9d9d537

Browse files
chore: updates naming
1 parent 8bebf2d commit 9d9d537

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

api/src/main/java/com/javadiscord/jdi/core/api/DiscordResponseParser.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import com.fasterxml.jackson.core.JsonProcessingException;
44
import com.fasterxml.jackson.databind.ObjectMapper;
5-
import com.javadiscord.jdi.core.api.utils.CacheHandler;
5+
import com.javadiscord.jdi.core.api.utils.CacheUpdateHandler;
66
import com.javadiscord.jdi.internal.api.DiscordRequest;
77
import com.javadiscord.jdi.internal.api.DiscordRequestDispatcher;
88
import com.javadiscord.jdi.internal.api.DiscordResponse;
@@ -15,11 +15,11 @@
1515
public class DiscordResponseParser {
1616
private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
1717
private final DiscordRequestDispatcher dispatcher;
18-
private final CacheHandler cacheHandler;
18+
private final CacheUpdateHandler cacheUpdateHandler;
1919

2020
public DiscordResponseParser(DiscordRequestDispatcher dispatcher, Cache cache) {
2121
this.dispatcher = dispatcher;
22-
this.cacheHandler = new CacheHandler(cache);
22+
this.cacheUpdateHandler = new CacheUpdateHandler(cache);
2323
}
2424

2525
public <T> AsyncResponse<List<T>> callAndParseList(Class<T> clazz, DiscordRequest request) {
@@ -31,7 +31,7 @@ public <T> AsyncResponse<List<T>> callAndParseList(Class<T> clazz, DiscordReques
3131
try {
3232
List<T> resultList = parseResponseFromList(clazz, response.body());
3333
asyncResponse.setResult(resultList);
34-
cacheHandler.cacheResult(resultList);
34+
cacheUpdateHandler.updateCache(resultList);
3535
} catch (Exception e) {
3636
asyncResponse.setException(e);
3737
}
@@ -59,7 +59,7 @@ public <T> AsyncResponse<List<T>> callAndParseMap(String key, DiscordRequest req
5959
try {
6060
List<T> resultList = parseResponseFromMap(key, response.body());
6161
asyncResponse.setResult(resultList);
62-
cacheHandler.cacheResult(resultList);
62+
cacheUpdateHandler.updateCache(resultList);
6363
} catch (Exception e){
6464
asyncResponse.setException(e);
6565
}
@@ -96,7 +96,7 @@ private <T> void success(
9696
try {
9797
T result = OBJECT_MAPPER.readValue(response.body(), type);
9898
asyncResponse.setResult(result);
99-
cacheHandler.cacheResult(result);
99+
cacheUpdateHandler.updateCache(result);
100100
} catch (JsonProcessingException e) {
101101
asyncResponse.setException(e);
102102
}

api/src/main/java/com/javadiscord/jdi/core/api/utils/CacheHandler.java renamed to api/src/main/java/com/javadiscord/jdi/core/api/utils/CacheUpdateHandler.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55
import java.lang.reflect.Field;
66
import java.util.List;
77

8-
public class CacheHandler {
8+
public class CacheUpdateHandler {
99

1010
private final Cache cache;
1111

12-
public CacheHandler(Cache cache) {
12+
public CacheUpdateHandler(Cache cache) {
1313
this.cache = cache;
1414
}
1515

16-
public <T> void cacheResult(T result) {
16+
public <T> void updateCache(T result) {
1717
try {
1818
Field guildIdField = result.getClass().getDeclaredField("guildId");
1919
Field idField = result.getClass().getDeclaredField("id");
@@ -24,11 +24,12 @@ public <T> void cacheResult(T result) {
2424
cache.getCacheForGuild(guildId).add(id, result);
2525
} catch (IllegalAccessException | NoSuchFieldException e) {
2626
// NoSuchFieldException means we don't want to cache result
27+
// Other exceptions should be caught in payload validation layer
2728
}
2829
}
2930

30-
public <T> void cacheResult(List<T> resultList) {
31-
resultList.forEach(this::cacheResult);
31+
public <T> void updateCache(List<T> resultList) {
32+
resultList.forEach(this::updateCache);
3233
}
3334

3435
private long getLongFromField(Field field) throws IllegalAccessException {

0 commit comments

Comments
 (0)