Add Qodana GHA and fixes

Author: surajkumar

.github/workflows/qodana_code_quality.yml

@@ -0,0 +1,20 @@
+name: Qodana
+on:
+  workflow_dispatch:
+  pull_request:
+  push:
+    branches:
+      - main
+      - slash-commands
+
+jobs:
+  qodana:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
+      - name: 'Qodana Scan'
+        uses: JetBrains/qodana-action@v2024.1
+        env:
+          QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }}

api/src/main/java/com/javadiscord/jdi/core/api/AutoModerationRequest.java

@@ -2,9 +2,9 @@
 
 import java.util.List;
 
+import com.javadiscord.jdi.core.api.builders.CreateAutoModerationRuleBuilder;
 import com.javadiscord.jdi.core.api.builders.ModifyAutoModerationRuleBuilder;
 import com.javadiscord.jdi.core.models.auto_moderation.AutoModerationRule;
-import com.javadiscord.jdi.core.request.builders.CreateAutoModerationRuleBuilder;
 import com.javadiscord.jdi.internal.api.auto_moderation.*;
 
 public class AutoModerationRequest {

api/src/main/java/com/javadiscord/jdi/core/api/builders/CreateAutoModerationRuleBuilder.java

@@ -1,4 +1,4 @@
-package com.javadiscord.jdi.core.request.builders;
+package com.javadiscord.jdi.core.api.builders;
 
 import java.util.List;
 import java.util.Optional;

example/lj-discord-bot/src/main/java/com/javadiscord/bot/utils/chatgpt/ChatGPT.java

@@ -104,9 +104,9 @@ public Optional<String[]> ask(String question) {
                     openAiHttpException.statusCode
                 )
             );
-        } catch (RuntimeException runtimeException) {
+        } catch (RuntimeException e) {
             logger.warn(
-                "There was an error using the OpenAI API: " + runtimeException.getMessage()
+                "There was an error using the OpenAI API: {}", e.getMessage()
             );
         }
         return Optional.empty();

example/lj-discord-bot/src/main/java/com/javadiscord/bot/utils/chatgpt/ChatGPTResponseParser.java

@@ -15,7 +15,7 @@ private ChatGPTResponseParser() {}
     public static String[] parse(String response) {
         String[] partedResponse = new String[] {response};
         if (response.length() > RESPONSE_LENGTH_LIMIT) {
-            logger.debug("Response to parse:\n" + response);
+            logger.debug("Response to parse:\n{}", response);
             partedResponse = partitionAiResponse(response);
         }
         return partedResponse;

qodana.yaml

@@ -0,0 +1,31 @@
+#-------------------------------------------------------------------------------#
+#               Qodana analysis is configured by qodana.yaml file               #
+#             https://www.jetbrains.com/help/qodana/qodana-yaml.html            #
+#-------------------------------------------------------------------------------#
+version: "1.0"
+
+#Specify inspection profile for code analysis
+profile:
+  name: qodana.starter
+
+#Enable inspections
+#include:
+#  - name: <SomeEnabledInspectionId>
+
+#Disable inspections
+#exclude:
+#  - name: <SomeDisabledInspectionId>
+#    paths:
+#      - <path/where/not/run/inspection>
+
+projectJDK: 21 #(Applied in CI/CD pipeline)
+
+#Execute shell command before Qodana execution (Applied in CI/CD pipeline)
+#bootstrap: sh ./prepare-qodana.sh
+
+#Install IDE plugins before Qodana execution (Applied in CI/CD pipeline)
+#plugins:
+#  - id: <plugin.id> #(plugin id can be found at https://plugins.jetbrains.com)
+
+#Specify Qodana linter for analysis (Applied in CI/CD pipeline)
+linter: jetbrains/qodana-jvm:latest