Sonar

Author: surajkumar

annotations/src/main/java/com/javadiscord/jdi/core/processor/loader/ComponentLoader.java

@@ -41,7 +41,7 @@ private void processClassFile(File classFile) {
         }
     }
 
-    private void processClassMethods(Class<?> clazz) throws Exception {
+    private void processClassMethods(Class<?> clazz) {
         for (Method method : clazz.getMethods()) {
             if (method.isAnnotationPresent(Component.class)) {
                 registerComponent(method);
@@ -51,10 +51,15 @@ private void processClassMethods(Class<?> clazz) throws Exception {
 
     private void registerComponent(
         Method method
-    ) throws InvocationTargetException, IllegalAccessException {
+    ) {
         Class<?> returnType = method.getReturnType();
         if (!COMPONENTS.containsKey(returnType)) {
-            COMPONENTS.put(returnType, method.invoke(null));
+            try {
+                COMPONENTS.put(returnType, method.invoke(null));
+            } catch (IllegalAccessException | InvocationTargetException e) {
+                LOGGER.error("Failed to register component {}", method.getName(), e);
+                return;
+            }
             LOGGER.info("Loaded component {}", returnType.getName());
         } else {
             LOGGER.error("Component {} already loaded", returnType.getName());

core/src/main/java/com/javadiscord/jdi/core/GatewayEventListenerAnnotations.java

@@ -255,12 +255,11 @@ private void invokeAnnotatedMethods(Class<? extends Annotation> annotationClass,
     private void invokeMethod(Object listener, Method method, Object event) {
         List<Object> paramOrder = getParamOrder(method, event);
         if (paramOrder.size() != method.getParameterCount()) {
-            throw new RuntimeException(
-                "Bound " + paramOrder.size() + " parameters but expected "
-                    + method.getParameterCount()
+            LOGGER.error(
+                "Bound {} parameters but expected {}", paramOrder.size(), method.getParameterCount()
             );
+            return;
         }
-
         try {
             LOGGER.trace("Invoking method {} with params {}", method.getName(), paramOrder);
             method.invoke(listener, paramOrder.toArray());