From a0d9c9f20ef5db65cf61b73174653b6fb19110d3 Mon Sep 17 00:00:00 2001 From: Shahzore Qureshi Date: Thu, 3 Mar 2016 12:10:42 -0600 Subject: [PATCH] Issue Fixed - Hidden Banner Not Shown I fixed an issue where the banner was not able to be shown again to the user after it is hidden. For example, if the user is typing, a developer can call the function ``` $(window).data('smartbanner').hide(); ``` to hide the banner so that the user has more room to type. Once the user is finished typing, the developer can call the function ``` $(window).data('smartbanner').show(); ``` to show the banner again. However, there was a bug in the show() function where the banner is not actually displayed to the user a second time. I have fixed the bug via calling the jQuery show() function after the banner animation. Thanks, Shahzore --- jquery.smartbanner.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jquery.smartbanner.js b/jquery.smartbanner.js index 3b4d6b1..104fa61 100644 --- a/jquery.smartbanner.js +++ b/jquery.smartbanner.js @@ -156,7 +156,7 @@ $(this.pushSelector).animate({paddingTop: this.origHtmlMargin + (this.bannerHeight * this.scale)}, this.options.speedIn, 'swing', callback); } else { if ($.support.transition) { - banner.animate({top:0},this.options.speedIn).addClass('shown'); + banner.animate({top:0},this.options.speedIn).addClass('shown').show(); var transitionCallback = function () { $('html').removeClass('sb-animation'); if (callback) {