Skip to content

Potential bug with route matching #568

@Yamaha32088

Description

@Yamaha32088

I am wondering if I have found a bug or if what I have found is the intended behavior. The bug I believe is the line below

const reactRouterMatch = matchPath(req.url, match as RouteProps);

It passes in req.url instead of pathname like it does in this file

const match = matchPath(pathname, { ...route, path: route.path || '*' });

The problem is that req.url can contain a query string for example https://example.com/?testing=123 which would make req.url equal to /?testing=123 and it would never actually match a route. I discovered this after trying to figure out why the match property was null inside of the Document getInitialProps function. Can someone tell me if this is the intended behavior for some reason?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions