-
-
Notifications
You must be signed in to change notification settings - Fork 200
Open
Description
I am wondering if I have found a bug or if what I have found is the intended behavior. The bug I believe is the line below
after.js/packages/after.js/src/renderApp.tsx
Line 141 in dbc362f
const reactRouterMatch = matchPath(req.url, match as RouteProps); |
It passes in req.url
instead of pathname
like it does in this file
const match = matchPath(pathname, { ...route, path: route.path || '*' }); |
The problem is that req.url
can contain a query string for example https://example.com/?testing=123
which would make req.url
equal to /?testing=123
and it would never actually match a route. I discovered this after trying to figure out why the match
property was null
inside of the Document getInitialProps
function. Can someone tell me if this is the intended behavior for some reason?
Metadata
Metadata
Assignees
Labels
No labels