Skip to content

Commit 45301f7

Browse files
authored
Typo Gready -> Greedy (#10)
1 parent da57488 commit 45301f7

File tree

6 files changed

+24
-24
lines changed

6 files changed

+24
-24
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ APP = FastAPI(lifespan=app_setup_teardown)
144144

145145
# Decorate the cached_query function with cache invalidation logic.
146146
@decorators.cache(
147-
strategy=strategies.Greedy( # Note: Assuming 'Gready' is a typo, corrected to 'Greedy'.
147+
strategy=strategies.Greedy(
148148
listener=listener,
149149
# Invalidate the cache only for 'update' operations on the database.
150150
predicate=lambda x: x.operation == "update",

src/pgcachewatch/strategies.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ def connection_healthy(self) -> bool:
1717
raise NotImplementedError
1818

1919

20-
class Gready(Strategy):
20+
class Greedy(Strategy):
2121
"""
2222
A strategy that clears events based on a predicate until a deadline is reached.
2323
"""

tests/test_decoraters.py

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@
99

1010

1111
@pytest.mark.parametrize("N", (1, 2, 4, 16, 64))
12-
async def test_gready_cache_decorator(N: int, pgconn: asyncpg.Connection) -> None:
12+
async def test_greedy_cache_decorator(N: int, pgconn: asyncpg.Connection) -> None:
1313
statistics = collections.Counter[str]()
1414
listener = listeners.PGEventQueue()
1515
await listener.connect(pgconn, models.PGChannel("test_cache_decorator"))
1616

1717
@decorators.cache(
18-
strategy=strategies.Gready(listener=listener),
18+
strategy=strategies.Greedy(listener=listener),
1919
statistics_callback=lambda x: statistics.update([x]),
2020
)
2121
async def now() -> datetime.datetime:
@@ -29,18 +29,18 @@ async def now() -> datetime.datetime:
2929

3030

3131
@pytest.mark.parametrize("N", (1, 2, 4, 16, 64))
32-
async def test_gready_cache_decorator_connection_closed(
32+
async def test_greedy_cache_decorator_connection_closed(
3333
N: int,
3434
pgconn: asyncpg.Connection,
3535
) -> None:
3636
listener = listeners.PGEventQueue()
3737
await listener.connect(
3838
pgconn,
39-
models.PGChannel("test_gready_cache_decorator_connection_closed"),
39+
models.PGChannel("test_greedy_cache_decorator_connection_closed"),
4040
)
4141
await pgconn.close()
4242

43-
@decorators.cache(strategy=strategies.Gready(listener=listener))
43+
@decorators.cache(strategy=strategies.Greedy(listener=listener))
4444
async def now() -> datetime.datetime:
4545
return datetime.datetime.now()
4646

@@ -49,17 +49,17 @@ async def now() -> datetime.datetime:
4949

5050

5151
@pytest.mark.parametrize("N", (1, 2, 4, 16, 64))
52-
async def test_gready_cache_decorator_exceptions(
52+
async def test_greedy_cache_decorator_exceptions(
5353
N: int,
5454
pgconn: asyncpg.Connection,
5555
) -> None:
5656
listener = listeners.PGEventQueue()
5757
await listener.connect(
5858
pgconn,
59-
models.PGChannel("test_gready_cache_decorator_exceptions"),
59+
models.PGChannel("test_greedy_cache_decorator_exceptions"),
6060
)
6161

62-
@decorators.cache(strategy=strategies.Gready(listener=listener))
62+
@decorators.cache(strategy=strategies.Greedy(listener=listener))
6363
async def raise_runtime_error() -> NoReturn:
6464
raise RuntimeError
6565

@@ -76,19 +76,19 @@ async def raise_runtime_error() -> NoReturn:
7676

7777

7878
@pytest.mark.parametrize("N", (1, 2, 4, 16, 64))
79-
async def test_gready_cache_identity(
79+
async def test_greedy_cache_identity(
8080
N: int,
8181
pgconn: asyncpg.Connection,
8282
) -> None:
8383
statistics = collections.Counter[str]()
8484
listener = listeners.PGEventQueue()
8585
await listener.connect(
8686
pgconn,
87-
models.PGChannel("test_gready_cache_decorator_exceptions"),
87+
models.PGChannel("test_greedy_cache_decorator_exceptions"),
8888
)
8989

9090
@decorators.cache(
91-
strategy=strategies.Gready(listener=listener),
91+
strategy=strategies.Greedy(listener=listener),
9292
statistics_callback=lambda x: statistics.update([x]),
9393
)
9494
async def identity(x: int) -> int:
@@ -102,19 +102,19 @@ async def identity(x: int) -> int:
102102

103103

104104
@pytest.mark.parametrize("N", (1, 2, 4, 16, 64))
105-
async def test_gready_cache_sleepy(
105+
async def test_greedy_cache_sleepy(
106106
N: int,
107107
pgconn: asyncpg.Connection,
108108
) -> None:
109109
statistics = collections.Counter[str]()
110110
listener = listeners.PGEventQueue()
111111
await listener.connect(
112112
pgconn,
113-
models.PGChannel("test_gready_cache_decorator_exceptions"),
113+
models.PGChannel("test_greedy_cache_decorator_exceptions"),
114114
)
115115

116116
@decorators.cache(
117-
strategy=strategies.Gready(listener=listener),
117+
strategy=strategies.Greedy(listener=listener),
118118
statistics_callback=lambda x: statistics.update([x]),
119119
)
120120
async def now() -> datetime.datetime:

tests/test_fastapi.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ async def fastapitestapp(
1717
listener = listeners.PGEventQueue()
1818
await listener.connect(pgconn, channel)
1919

20-
@decorators.cache(strategy=strategies.Gready(listener=listener))
20+
@decorators.cache(strategy=strategies.Greedy(listener=listener))
2121
async def slow_db_read() -> dict:
2222
await asyncio.sleep(0.1) # sim. a slow db-query.
2323
return {"now": datetime.datetime.now().isoformat()}

tests/test_integration.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ async def test_2_caching(
4343
cnt = 0
4444

4545
@decorators.cache(
46-
strategy=strategies.Gready(listener=listener),
46+
strategy=strategies.Greedy(listener=listener),
4747
statistics_callback=lambda x: statistics.update([x]),
4848
)
4949
async def fetch_sysconf() -> list:
@@ -69,7 +69,7 @@ async def test_3_cache_invalidation_update(
6969
)
7070

7171
@decorators.cache(
72-
strategy=strategies.Gready(listener=listener),
72+
strategy=strategies.Greedy(listener=listener),
7373
statistics_callback=lambda x: statistics.update([x]),
7474
)
7575
async def fetch_sysconf() -> list:
@@ -103,7 +103,7 @@ async def test_3_cache_invalidation_insert(
103103
)
104104

105105
@decorators.cache(
106-
strategy=strategies.Gready(listener=listener),
106+
strategy=strategies.Greedy(listener=listener),
107107
statistics_callback=lambda x: statistics.update([x]),
108108
)
109109
async def fetch_sysconf() -> list:
@@ -138,7 +138,7 @@ async def test_3_cache_invalidation_delete(
138138
)
139139

140140
@decorators.cache(
141-
strategy=strategies.Gready(listener=listener),
141+
strategy=strategies.Greedy(listener=listener),
142142
statistics_callback=lambda x: statistics.update([x]),
143143
)
144144
async def fetch_sysconf() -> list:

tests/test_strategies.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@
77

88

99
@pytest.mark.parametrize("N", (4, 16, 64))
10-
async def test_gready_strategy(N: int, pgconn: asyncpg.Connection) -> None:
11-
channel = models.PGChannel("test_gready_strategy")
10+
async def test_greedy_strategy(N: int, pgconn: asyncpg.Connection) -> None:
11+
channel = models.PGChannel("test_greedy_strategy")
1212

1313
listener = listeners.PGEventQueue()
1414
await listener.connect(pgconn, channel)
1515

16-
strategy = strategies.Gready(
16+
strategy = strategies.Greedy(
1717
listener=listener,
1818
predicate=lambda e: e.operation == "insert",
1919
)

0 commit comments

Comments
 (0)