Performance issue using trigger-based rollup

[lemerv]

I'm just getting my feet wet with Apex Rollups. It's an awesome tool!

However, I'm noticing a real performance issue that I think is being caused by the tool. I have 6 cmdc rollups configured (all SUM operations using a WHERE clause). When I insert/update/delete a child record, there is a noticeable lag as the save operation occurs.

Running some debugs and looking at the Performance Tree, the culprit seems to be a query that ApexRollups is running. Interestingly, even if disable rollups in Custom Settings, this query still runs and causes a performance hit. I'm assuming this is getting the cmdt config for all rollups. See screenshot below.

There are no other triggers on this object. And the one trigger is purely for ApexRollups, no other code in there.

Is this normal? 1.3s seems long for a query.

Thanks

[jamessimone]

This performance hit is a consequence of using the field/entity definition powered lookups on Rollup metadata. There is a proposed fix for this that comes out in the next version, but it requires filling out all Rollup metadata yourself using the text-based overrides instead of the dropdown based methods for filling in object and field names.

I have also brought up the issue of the speed of custom metadata queries internally and it's my hope that will also eventually be addressed

[lemerv]

Ok thanks for clarifying. Glad to hear there is a fix. I'm more than happy to use the text fields in place of the metadata powered pick lists if it fixed the performance. Any eta on the release? Thanks

[lemerv]

Hi @jamessimone I see you've implemented this in this release: #698
Thanks!

I have enabled the "Should Optimise CMDT Queries" checkbox on my rollup settings. I have also updated my Rollup record as below:

However, I'm getting an error:
ApexRollupContact: execution of AfterUpdate caused by: System.SObjectException: SObject row was retrieved via SOQL without querying the requested field: Rollup__mdt.UltimateParentLookup__r Class.RollupRepository.getRollupMetadata: line 170, column 1 Class.Rollup.getMetadataFromCache: line 1867, column 1 Class.Rollup.getRollupMetadataBySObject: line 2631, column 1 Class.Rollup.runFromTrigger: line 1721, column 1 Trigger.ApexRollupContact: line 3, column 1

Had a bit of a play around but couldn't get it to work.

[lemerv]

Some further info - I switched all my rollups to use the original field/entity definition setup and now it is working again.

[jamessimone]

I released #713 and it would be good to confirm that this is still happening on the most up-to-date version. I have not been able to repro this issue locally.

[lemerv]

Thanks. Looks like that has fixed it. I'll keep testing and let you know if any issues

[jamessimone]

Sounds good, sorry for the trouble!

[lemerv]

No problem, thanks for the great tool!