Use zalas/phpunit-doubles to simplfiy test double creation

Author: jakzal

composer.json

@@ -13,7 +13,8 @@
         "symfony/dependency-injection": "^3.4 || ^4.0",
         "symfony/http-kernel": "^3.4 || ^4.0",
         "zalas/phpunit-globals": "^1.0",
-        "symfony/framework-bundle": "^3.4||^4.0"
+        "symfony/framework-bundle": "^3.4||^4.0",
+        "zalas/phpunit-doubles": "^1.2"
     },
     "autoload": {
         "psr-4": {

tests/Symfony/Compiler/Discovery/PropertyDiscoveryTest.php

@@ -15,9 +15,12 @@
 use Zalas\Injector\Service\Extractor;
 use Zalas\Injector\Service\ExtractorFactory;
 use Zalas\Injector\Service\Property;
+use Zalas\PHPUnit\Doubles\TestCase\TestDoubles;
 
 class PropertyDiscoveryTest extends TestCase
 {
+    use TestDoubles;
+
     /**
      * @var PropertyDiscovery
      */
@@ -39,10 +42,6 @@ class PropertyDiscoveryTest extends TestCase
 
     protected function setUp()
     {
-        $this->extractorFactory = $this->prophesize(ExtractorFactory::class);
-        $this->extractor = $this->prophesize(Extractor::class);
-        $this->classFinder = $this->prophesize(ClassFinder::class);
-
         $this->discovery = new PropertyDiscovery($this->classFinder->reveal(), $this->extractorFactory->reveal());
 
         $this->classFinder->findImplementations(Argument::any())->willReturn([]);

tests/Symfony/Compiler/ExposeServicesForTestsPassTest.php

@@ -18,9 +18,12 @@
 use Zalas\Injector\PHPUnit\Tests\Symfony\Compiler\Fixtures\TestCase1;
 use Zalas\Injector\PHPUnit\Tests\Symfony\Compiler\Fixtures\TestCase2;
 use Zalas\Injector\Service\Property;
+use Zalas\PHPUnit\Doubles\TestCase\TestDoubles;
 
 class ExposeServicesForTestsPassTest extends TestCase
 {
+    use TestDoubles;
+
     /**
      * @var ExposeServicesForTestsPass
      */
@@ -33,7 +36,6 @@ class ExposeServicesForTestsPassTest extends TestCase
 
     protected function setUp()
     {
-        $this->discovery = $this->prophesize(PropertyDiscovery::class);
         $this->pass = new ExposeServicesForTestsPass($this->discovery->reveal());
     }
 

tests/TestListener/TestCaseContainerFactoryTest.php

@@ -9,16 +9,19 @@
 use Zalas\Injector\PHPUnit\TestCase\ServiceContainerTestCase;
 use Zalas\Injector\PHPUnit\TestListener\TestCaseContainerFactory;
 use Zalas\Injector\Service\ContainerFactory;
+use Zalas\PHPUnit\Doubles\TestCase\TestDoubles;
 
 class TestCaseContainerFactoryTest extends TestCase
 {
+    use TestDoubles;
+
     /**
      * @var TestCaseContainerFactory
      */
     private $factory;
 
     /**
-     * @var ContainerInterface
+     * @var ContainerInterface|ObjectProphecy
      */
     private $container;
 
@@ -29,9 +32,6 @@ class TestCaseContainerFactoryTest extends TestCase
 
     protected function setUp()
     {
-        $this->container = $this->prophesize(ContainerInterface::class)->reveal();
-        $this->testCase = $this->prophesize(ServiceContainerTestCase::class);
-
         $this->factory = new TestCaseContainerFactory($this->testCase->reveal());
     }
 
@@ -46,6 +46,6 @@ public function test_it_uses_the_test_case_to_create_a_container()
 
         $createdContainer = $this->factory->create();
 
-        $this->assertSame($this->container, $createdContainer);
+        $this->assertSame($this->container->reveal(), $createdContainer);
     }
 }