v4.4.1 (#100)

jaebradley · web-flow · commit 58018351e05c · 2019-09-30T20:05:21.000-07:00
Resolves #99. BBref added stats tables for quarters, which also had `basic` in the `id` value. ![image](https://user-images.githubusercontent.com/8136030/65930744-abaad580-e3bb-11e9-9484-85a3fbcfb7cc.png) This meant that the number of matching footers was much higher. Instead, I check for `game-basic` `id` values. This probably requires a more robust solution in the future, but this is my strategy for now.
diff --git a/basketball_reference_web_scraper/parsers/box_scores/teams.py b/basketball_reference_web_scraper/parsers/box_scores/teams.py
@@ -35,7 +35,7 @@ def parse_team_totals(page):
     footers = [
         footer
         for table in tables
-        if "basic" in table.attrib["id"]
+        if "game-basic" in table.attrib["id"]
         for footer in table.xpath("tfoot")
     ]
     return [
diff --git a/setup.py b/setup.py
@@ -5,7 +5,7 @@
 
 setuptools.setup(
     name="basketball_reference_web_scraper",
-    version="4.4.0",
+    version="4.4.1",
     author="Jae Bradley",
     author_email="jae.b.bradley@gmail.com",
     license="MIT",
diff --git a/tests/201701010ATL.html b/tests/201701010ATL.html

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ def parse_team_totals(page):`
`35`	`35`	`footers = [`
`36`	`36`	`footer`
`37`	`37`	`for table in tables`
`38`		`- if "basic" in table.attrib["id"]`
	`38`	`+ if "game-basic" in table.attrib["id"]`
`39`	`39`	`for footer in table.xpath("tfoot")`
`40`	`40`	`]`
`41`	`41`	`return [`