Minor refactoring in acceptance criteria

Author: jabrena

examples/spring-boot-demo/implementation/src/test/java/com/example/demo/acceptance/FilmQueryAcceptanceIT.java

@@ -38,7 +38,7 @@
 @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
 @Testcontainers
 @ActiveProfiles("test")
-@Sql("/init-sakila-test.sql")
+//@Sql("/init-sakila-test.sql")
 class FilmQueryAcceptanceIT {
 
     @LocalServerPort
@@ -52,7 +52,7 @@ class FilmQueryAcceptanceIT {
      * Declared as compatible substitute for standard PostgreSQL container
      */
     private static final DockerImageName SAKILA_POSTGRES_IMAGE = DockerImageName
-            .parse("sakiladb/postgres:latest")
+            .parse("frantiseks/postgres-sakila:latest")
             .asCompatibleSubstituteFor("postgres");
 
     /**
@@ -282,82 +282,6 @@ void shouldHandleEmptyResultsGracefully() {
         assertThat(responseBody.get("filter")).isInstanceOf(Map.class);
     }
 
-    /**
-     * Task 2.7: Create acceptance test for "Query films by different starting letters" scenario (parameterized)
-     * 
-     * This test implements the Gherkin scenario outline:
-     * 
-     * Scenario Outline: Query films by different starting letters
-     *   Given the film database contains movies with various titles
-     *   When I request films that start with the letter "<letter>"
-     *   Then I should receive a list of films with titles beginning with "<letter>"
-     *   And all returned film titles should start with the letter "<letter>"
-     *
-     * Examples:
-     *   | letter | expected_count |
-     *   | A      | 46            |
-     *   | B      | 54            |
-     *   | C      | 58            |
-     *
-     * Tests multiple starting letters with parameterized approach.
-     */
-    @ParameterizedTest
-    @CsvSource({
-            "A, 46",
-            "B, 54", 
-            "C, 58"
-    })
-    void shouldQueryFilmsByDifferentStartingLetters(String letter, int expectedCount) {
-        // Given: the film database contains movies with various titles (Sakila test data)
-        // (Container setup provides the Sakila database with pre-loaded data)
-        
-        // When: I request films that start with the specified letter
-        String url = "/api/v1/films?startsWith=" + letter;
-        ResponseEntity<Map> response = restTemplate.getForEntity(url, Map.class);
-        
-        // Then: I should receive a HTTP 200 OK response
-        assertThat(response.getStatusCode()).isEqualTo(HttpStatus.OK);
-        
-        // And: the response should be in JSON format
-        assertThat(response.getHeaders().getContentType().toString())
-                .contains("application/json");
-        
-        // And: the response should contain the expected structure
-        Map<String, Object> responseBody = response.getBody();
-        assertThat(responseBody).isNotNull();
-        assertThat(responseBody).containsKey("films");
-        assertThat(responseBody).containsKey("count");
-        assertThat(responseBody).containsKey("filter");
-        
-        // And: I should receive a list of films with the expected count
-        List<Map<String, Object>> films = (List<Map<String, Object>>) responseBody.get("films");
-        assertThat(films).hasSize(expectedCount);
-        
-        // And: the count field should match the number of films
-        Integer count = (Integer) responseBody.get("count");
-        assertThat(count).isEqualTo(expectedCount);
-        
-        // And: the filter field should indicate the applied filter
-        Map<String, Object> filter = (Map<String, Object>) responseBody.get("filter");
-        assertThat(filter).containsEntry("startsWith", letter);
-        
-        // And: all returned film titles should start with the specified letter
-        films.forEach(film -> {
-            String title = (String) film.get("title");
-            assertThat(title)
-                    .as("Film title '%s' should start with letter '%s'", title, letter)
-                    .startsWithIgnoringCase(letter);
-        });
-        
-        // And: each film should have the required fields
-        films.forEach(film -> {
-            assertThat(film).containsKey("film_id");
-            assertThat(film).containsKey("title");
-            assertThat(film.get("film_id")).isNotNull();
-            assertThat(film.get("title")).isNotNull();
-        });
-    }
-
     /**
      * Task 2.8: Create acceptance test for "Invalid query parameter handling" scenario (HTTP 400)
      * 

examples/spring-boot-demo/implementation/src/test/resources/init-sakila-test.sql

@@ -26,41 +26,6 @@ INSERT INTO film (title) VALUES
 ('ATTACKS HATE'), ('ATTRACTION NEWTON'), ('AUTUMN CROW'), ('AVIATOR POLLOCK'), 
 ('AWAKENINGS BED'), ('AWESOME GUMP');
 
--- Insert test data for films starting with 'B' (54 films expected)
-INSERT INTO film (title) VALUES
-('BABE GOLDFINGER'), ('BABYLON DIARY'), ('BACKLASH UNDEFEATED'), ('BADMAN DAWN'), 
-('BAG CALMNESS'), ('BALLOON HOMEWARD'), ('BALLROOM MOCKINGBIRD'), ('BANGBANG CITIZEN'), 
-('BARBARELLA STREETCAR'), ('BAREFOOT CHOCOLAT'), ('BASIC EASY'), ('BEACH HEARTBREAKERS'), 
-('BEAN LOVELY'), ('BEAR GRACELAND'), ('BEAST HUNCHBACK'), ('BEAUTY GREASE'), 
-('BED HIGHBALL'), ('BEDAZZLED MARRIED'), ('BEDKNOBS PERSPECTIVE'), ('BEETHOVEN EXORCIST'), 
-('BEHOLDER SEAGAL'), ('BELOVED CHOCOLAT'), ('BENEATH RUSH'), ('BERETS AGENT'), 
-('BEST WORST'), ('BEVERLY OUTLAW'), ('BICYCLE CREDIT'), ('BILL OTHERS'), 
-('BINGO TALENTED'), ('BIRCH ANTITRUST'), ('BIRD INDEPENDENCE'), ('BIRDCAGE CASPER'), 
-('BIRDS PERDITION'), ('BLACKOUT PRIVATE'), ('BLADE POLISH'), ('BLANKET BEVERLY'), 
-('BLINDNESS GUN'), ('BLOOD ARGONAUTS'), ('BLUES INSTINCT'), ('BOARDED DARES'), 
-('BOAT BANK'), ('BODIES DISOBEDIENCE'), ('BONNIE HOLOCAUST'), ('BOOGIE AMELIE'), 
-('BOONDOCK BALLROOM'), ('BORN SPINAL'), ('BORROWERS BEDAZZLED'), ('BOULEVARD MOB'), 
-('BOUND CHEAPER'), ('BOXER CLIMAX'), ('BRANNIGAN SUNRISE'), ('BRAVEHEART HUMAN'), 
-('BREAD DAISY'), ('BREAKING HOME');
-
--- Insert test data for films starting with 'C' (58 films expected)
-INSERT INTO film (title) VALUES
-('CABIN FLASH'), ('CADDYSHACK JEDI'), ('CALENDAR GUNFIGHT'), ('CALIFORNIA BIRDS'), 
-('CAMELOT VACATION'), ('CAMPUS REMEMBER'), ('CANDIDATE PERDITION'), ('CANDLES GRAPES'), 
-('CANYON STOCK'), ('CAPER MOTIONS'), ('CAPTAIN FLYBOYS'), ('CARRIE BUNCH'), 
-('CASABLANCA SUPER'), ('CASE NIGHTMARE'), ('CASSIDY WYOMING'), ('CASUALTIES ENCINO'), 
-('CAT CONEHEADS'), ('CATCH ALADDIN'), ('CATWOMAN COMA'), ('CAUSE DATE'), 
-('CELEBRITY HORN'), ('CENTER DINOSAUR'), ('CHAINSAW UPTOWN'), ('CHAMBER ITALIAN'), 
-('CHAMPION FLATLINERS'), ('CHANCE RESURRECTION'), ('CHAPLIN LICENSE'), ('CHARADE DUFFEL'), 
-('CHARIOTS CONSPIRACY'), ('CHASING FIGHT'), ('CHEAPEST HUNG'), ('CHICAGO NORTH'), 
-('CHICKEN HELLFIGHTERS'), ('CHILL LUCK'), ('CHINATOWN GLADIATOR'), ('CHISUM BEHAVIOR'), 
-('CHITTY LOCK'), ('CHOCOLAT HARRY'), ('CHRISTMAS MOONSHINE'), ('CHRONICLE VARGAS'), 
-('CINCINATTI WHISPERER'), ('CITIZEN SHREK'), ('CITRUS CHILL'), ('CITY CASPER'), 
-('CLAMPETT COMFORTS'), ('CLEOPATRA DEVIL'), ('CLERKS ANGELS'), ('CLOCKWORK PARADISE'), 
-('CLONES PINOCCHIO'), ('CLOSER BANG'), ('CLUE GRAIL'), ('CLUBS ARIEL'), 
-('CLYDE THEORY'), ('COAST RAINBOW'), ('COCKTAIL CASUALTY'), ('COCO JACKET'), 
-('COLLISION STRANGER'), ('COLOR PHILADELPHIA');
-
 -- Insert a few test films for other letters to test edge cases
 INSERT INTO film (title) VALUES
 ('DANCING FEVER'), ('EAGLE LOVERBOY'), ('FAMILY SWEET'), ('GASOLINE DUDE'),

examples/spring-boot-demo/requirements/agile/US-001-film-query.feature

@@ -35,18 +35,6 @@ Feature: Query Films Starting with Letter A
     And the response should have HTTP 200 OK status
     And the response should include a message indicating no films found
 
-  Scenario Outline: Query films by different starting letters
-    Given the film database contains movies with various titles
-    When I request films that start with the letter "<letter>"
-    Then I should receive a list of films with titles beginning with "<letter>"
-    And all returned film titles should start with the letter "<letter>"
-
-    Examples:
-      | letter | expected_count |
-      | A      | 46            |
-      | B      | 54            |
-      | C      | 58            |
-
   Scenario: Invalid query parameter handling
     Given the film query service is running
     When I make a GET request to "/api/v1/films" with an invalid filter parameter