review comments from PR #41

Author: benedicthsieh

rest_framework_datatables/filters.py

@@ -74,8 +74,8 @@ def filter_queryset(self, request, queryset, view):
 
         # order queryset
         if len(ordering):
-            if hasattr(view, '_datatables_additional_order_by'):
-                additional = view._datatables_additional_order_by
+            if hasattr(view, 'datatables_additional_order_by'):
+                additional = view.datatables_additional_order_by
                 # Django will actually only take the first occurrence if the
                 # same column is added multiple times in an order_by, but it
                 # feels cleaner to double check for duplicate anyway.

tests/test_filter.py

@@ -17,7 +17,7 @@ class TestFilterTestCase(TestCase):
     class TestAPIView(ListAPIView):
         serializer_class = AlbumSerializer
         pagination_class = DatatablesLimitOffsetPagination
-        _datatables_additional_order_by = 'year'
+        datatables_additional_order_by = 'year'
 
         def get_queryset(self):
             return Album.objects.all()