[Enhancement] Support content-disposition header in subtitles endpoint #5211

syeopite · 2025-03-20T05:37:49Z

When trying to download subtitles through the download widget Invidious doesn't add an attachment content-disposition header to the response, resulting in the browser opening the file instead of downloading it.

This should be a trivial fix. The content disposition header can be set right before the captions handler gets called:

invidious/src/invidious/routes/watch.cr

Lines 318 to 324 in 70ff463

    
           if label = download_widget["label"]? 
        
             # URL params specific to /api/v1/captions/:id 
        
             env.params.url["id"] = video_id 
        
             env.params.query["title"] = filename 
        
             env.params.query["label"] = URI.decode_www_form(label.as_s) 
        
             return Invidious::Routes::API::V1::Videos.captions(env)

ekansh2 · 2025-04-09T19:31:31Z

@syeopite MR created for the issue.

syeopite added enhancement Improvement of an existing feature good first issue Good for newcomers labels Mar 20, 2025

syeopite linked a pull request May 10, 2025 that will close this issue

fix: content-disposition-header added #5234

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enhancement] Support content-disposition header in subtitles endpoint #5211

[Enhancement] Support content-disposition header in subtitles endpoint #5211

syeopite commented Mar 20, 2025 •

edited

Loading

ekansh2 commented Apr 9, 2025 •

edited

Loading

[Enhancement] Support content-disposition header in subtitles endpoint #5211

[Enhancement] Support content-disposition header in subtitles endpoint #5211

Comments

syeopite commented Mar 20, 2025 • edited Loading

ekansh2 commented Apr 9, 2025 • edited Loading

syeopite commented Mar 20, 2025 •

edited

Loading

ekansh2 commented Apr 9, 2025 •

edited

Loading