Skip to content

Add git and Git-lfs package for FastBack mod #2780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BlownIntoSpace opened this issue Apr 16, 2024 · 2 comments · Fixed by #2781
Closed

Add git and Git-lfs package for FastBack mod #2780

BlownIntoSpace opened this issue Apr 16, 2024 · 2 comments · Fixed by #2781

Comments

@BlownIntoSpace
Copy link
Contributor

Enhancement Type

A completely new feature

Describe the enhancement

The FastBack mod uses git to manage world versions. I believe it used to use jgit in the past, but now requires git and git-lfs to be natively installed.

I have tested it by installing the git binaries using

FROM itzg/minecraft-server:latest
RUN apt-get update && apt-get install -y git git-lfs

and it seems to run well when it works, but the fastback mod does seem to be unable to find the git executables half the time if i dont manually rebuild the image every time i launch the server, but that could just be an issue on my end.

Git would also require a .gitconfig file in the containers /etc/gitconfig directory, which i just set to something like this:

[user]
	name = Minecraft Server
	email = server@example.com
	username = minecraft-server
[init]
	defaultBranch = main

which could be easily overridden using volumes if anyone wanted to have their own info in there.

@itzg
Copy link
Owner

itzg commented Apr 16, 2024

git is already installed, but git-lfs would indeed need to be added here (and same for other distros)

Good point about the default gitconfig file. I would have completely missed that.

If you want to PR those changes, then that would work for me.

@itzg itzg linked a pull request Apr 17, 2024 that will close this issue
@cn-ml
Copy link

cn-ml commented Apr 17, 2024

Thanks a lot, previously i always built my own images with

build:
  dockerfile_inline: |-
    FROM itzg/minecraft-server:java17
    RUN apt-get update \
      && apt-get install -y git-lfs \
      && rm -rf /var/lib/apt/lists/*
  tags:
    - itzg/minecraft-server:java17-gitlfs

This makes it a lot easier to update my images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants