Skip to content

Commit f1c2442

Browse files
Rename instance_gpu tesla to v100 (#112)
* Rename instance_gpu tesla => v100 * Restyled by prettier-markdown Co-authored-by: Restyled.io <commits@restyled.io>
1 parent 5f62a02 commit f1c2442

File tree

5 files changed

+42
-35
lines changed

5 files changed

+42
-35
lines changed

README.md

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ resource "iterative_machine" "machine" {
108108
region = "us-west"
109109
instance_type = "m"
110110
# Uncomment it if GPU is needed:
111-
# instance_gpu = "tesla"
111+
# instance_gpu = "v100"
112112
}
113113
```
114114

@@ -139,7 +139,7 @@ resource "iterative_machine" "machine" {
139139
region = "us-west"
140140
instance_type = "m"
141141
# Uncomment it if GPU is needed:
142-
# instance_gpu = "tesla"
142+
# instance_gpu = "v100"
143143
}
144144
```
145145

@@ -229,7 +229,7 @@ resource "iterative_machine" "machine" {
229229
instance_hdd_size = "10"
230230
instance_type = "m"
231231
# Uncomment it if GPU is needed:
232-
# instance_gpu = "tesla"
232+
# instance_gpu = "v100"
233233
}
234234
```
235235

@@ -258,7 +258,7 @@ resource "iterative_machine" "machine" {
258258
instance_hdd_size = "10"
259259
instance_type = "m"
260260
## Uncomment it if GPU is needed:
261-
# instance_gpu = "tesla"
261+
# instance_gpu = "v100"
262262
}
263263
```
264264

@@ -345,17 +345,17 @@ is not currently supported.
345345
The instance type in AWS is calculated by joining the `instance_type` and
346346
`instance_gpu` values.
347347

348-
| type | gpu | aws |
349-
| ---- | ----- | ----------- |
350-
| m | | m5.2xlarge |
351-
| l | | m5.8xlarge |
352-
| xl | | m5.16xlarge |
353-
| m | k80 | p2.xlarge |
354-
| l | k80 | p2.8xlarge |
355-
| xl | k80 | p2.16xlarge |
356-
| m | tesla | p3.xlarge |
357-
| l | tesla | p3.8xlarge |
358-
| xl | tesla | p3.16xlarge |
348+
| type | gpu | aws |
349+
| ---- | ---- | ----------- |
350+
| m | | m5.2xlarge |
351+
| l | | m5.8xlarge |
352+
| xl | | m5.16xlarge |
353+
| m | k80 | p2.xlarge |
354+
| l | k80 | p2.8xlarge |
355+
| xl | k80 | p2.16xlarge |
356+
| m | v100 | p3.xlarge |
357+
| l | v100 | p3.8xlarge |
358+
| xl | v100 | p3.16xlarge |
359359

360360
| region | aws |
361361
| -------- | ---------- |
@@ -374,17 +374,17 @@ The instance type in AWS is calculated by joining the `instance_type` and
374374
The instance type in Azure is calculated by joining the `instance_type` and
375375
`instance_gpu`
376376

377-
| type | gpu | azure |
378-
| ---- | ----- | ----------------- |
379-
| m | | Standard_F8s_v2 |
380-
| l | | Standard_F32s_v2 |
381-
| xl | | Standard_F64s_v2 |
382-
| m | k80 | Standard_NC6 |
383-
| l | k80 | Standard_NC12 |
384-
| xl | k80 | Standard_NC24 |
385-
| m | tesla | Standard_NC6s_v3 |
386-
| l | tesla | Standard_NC12s_v3 |
387-
| xl | tesla | Standard_NC24s_v3 |
377+
| type | gpu | azure |
378+
| ---- | ---- | ----------------- |
379+
| m | | Standard_F8s_v2 |
380+
| l | | Standard_F32s_v2 |
381+
| xl | | Standard_F64s_v2 |
382+
| m | k80 | Standard_NC6 |
383+
| l | k80 | Standard_NC12 |
384+
| xl | k80 | Standard_NC24 |
385+
| m | v100 | Standard_NC6s_v3 |
386+
| l | v100 | Standard_NC12s_v3 |
387+
| xl | v100 | Standard_NC24s_v3 |
388388

389389
| region | azure |
390390
| -------- | ----------- |

iterative/aws/provider.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -380,9 +380,9 @@ func getInstanceType(instanceType string, instanceGPU string) string {
380380
instanceTypes["mk80"] = "p2.xlarge"
381381
instanceTypes["lk80"] = "p2.8xlarge"
382382
instanceTypes["xlk80"] = "p2.16xlarge"
383-
instanceTypes["mtesla"] = "p3.xlarge"
384-
instanceTypes["ltesla"] = "p3.8xlarge"
385-
instanceTypes["xltesla"] = "p3.16xlarge"
383+
instanceTypes["mv100"] = "p3.xlarge"
384+
instanceTypes["lv100"] = "p3.8xlarge"
385+
instanceTypes["xlv100"] = "p3.16xlarge"
386386

387387
if val, ok := instanceTypes[instanceType+instanceGPU]; ok {
388388
return val

iterative/azure/provider.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -376,9 +376,9 @@ func getInstanceType(instanceType string, instanceGPU string) string {
376376
instanceTypes["mk80"] = "Standard_NC6"
377377
instanceTypes["lk80"] = "Standard_NC12"
378378
instanceTypes["xlk80"] = "Standard_NC24"
379-
instanceTypes["mtesla"] = "Standard_NC6s_v3"
380-
instanceTypes["ltesla"] = "Standard_NC12s_v3"
381-
instanceTypes["xltesla"] = "Standard_NC24s_v3"
379+
instanceTypes["mv100"] = "Standard_NC6s_v3"
380+
instanceTypes["lv100"] = "Standard_NC12s_v3"
381+
instanceTypes["xlv100"] = "Standard_NC24s_v3"
382382

383383
if val, ok := instanceTypes[instanceType+instanceGPU]; ok {
384384
return val

iterative/kubernetes/provider.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ func getInstanceType(instanceType string, instanceGPU string) (map[string]map[st
346346
"cores": {"count": "64"},
347347
"memory": {"amount": "768Gi"},
348348
}
349-
instanceTypes["mtesla"] = map[string]map[string]string{
349+
instanceTypes["mv100"] = map[string]map[string]string{
350350
"accelerator": {
351351
"count": "1",
352352
"type": "nvidia.com/gpu",
@@ -355,7 +355,7 @@ func getInstanceType(instanceType string, instanceGPU string) (map[string]map[st
355355
"cores": {"count": "8"},
356356
"memory": {"amount": "64Gi"},
357357
}
358-
instanceTypes["ltesla"] = map[string]map[string]string{
358+
instanceTypes["lv100"] = map[string]map[string]string{
359359
"accelerator": {
360360
"count": "4",
361361
"type": "nvidia.com/gpu",
@@ -364,7 +364,7 @@ func getInstanceType(instanceType string, instanceGPU string) (map[string]map[st
364364
"cores": {"count": "32"},
365365
"memory": {"amount": "256Gi"},
366366
}
367-
instanceTypes["xltesla"] = map[string]map[string]string{
367+
instanceTypes["xlv100"] = map[string]map[string]string{
368368
"accelerator": {
369369
"count": "8",
370370
"type": "nvidia.com/gpu",

iterative/resource_runner.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,13 @@ func resourceRunnerCreate(ctx context.Context, d *schema.ResourceData, m interfa
183183
}
184184

185185
d.Set("startup_script", startupScript)
186+
if d.Get("instance_gpu") == "tesla" {
187+
diags = append(diags, diag.Diagnostic{
188+
Severity: diag.Warning,
189+
Summary: fmt.Sprintf("GPU model 'tesla' has been deprecated; please use 'v100' instead"),
190+
})
191+
d.Set("instance_gpu", "v100")
192+
}
186193

187194
if len(d.Get("cloud").(string)) == 0 {
188195
diags = append(diags, diag.Diagnostic{

0 commit comments

Comments
 (0)