Escape dots in GCP OIDC regular expression (#554)

0x2b3bfa0 · web-flow · commit e9447162b2f8 · 2022-05-04T16:48:12.000+02:00
* Escape dots in regular expression

* Use raw string literal to allow single backslashes
diff --git a/iterative/gcp/provider.go b/iterative/gcp/provider.go
@@ -384,7 +384,7 @@ func coerceOIDCCredentials(credentialsJSON []byte) (string, error) {
 	}
 
 	if url, ok := credentials["service_account_impersonation_url"].(string); ok {
-		re := regexp.MustCompile("^https://iamcredentials.googleapis.com/v1/projects/-/serviceAccounts/.+?@(?P<project>.+).iam.gserviceaccount.com:generateAccessToken$")
+		re := regexp.MustCompile(`^https://iamcredentials\.googleapis\.com/v1/projects/-/serviceAccounts/.+?@(?P<project>.+)\.iam\.gserviceaccount\.com:generateAccessToken$`)
 		if match := re.FindStringSubmatch(url); match != nil {
 			return match[1], nil
 		}

Original file line number	Diff line number	Diff line change
`@@ -384,7 +384,7 @@ func coerceOIDCCredentials(credentialsJSON []byte) (string, error) {`
`384`	`384`	`}`
`385`	`385`
`386`	`386`	`if url, ok := credentials["service_account_impersonation_url"].(string); ok {`
`387`		`- re := regexp.MustCompile("^https://iamcredentials.googleapis.com/v1/projects/-/serviceAccounts/.+?@(?P<project>.+).iam.gserviceaccount.com:generateAccessToken$")`
	`387`	+ re := regexp.MustCompile(`^https://iamcredentials\.googleapis\.com/v1/projects/-/serviceAccounts/.+?@(?P<project>.+)\.iam\.gserviceaccount\.com:generateAccessToken$`)
`388`	`388`	`if match := re.FindStringSubmatch(url); match != nil {`
`389`	`389`	`return match[1], nil`
`390`	`390`	`}`