Use any availability zone on aws (#594)

* Use any availability zone on `aws`

* Restyled by gofmt

* Fix major blunder

Co-authored-by: Restyled.io <commits@restyled.io>

Author: 0x2b3bfa0

task/aws/resources/data_source_default_vpc_subnet.go renamed to task/aws/resources/data_source_default_vpc_subnets.go

@@ -11,28 +11,32 @@ import (
 	"terraform-provider-iterative/task/common"
 )
 
-func NewDefaultVPCSubnet(client *client.Client, defaultVpc *DefaultVPC) *DefaultVPCSubnet {
-	d := new(DefaultVPCSubnet)
+func NewDefaultVPCSubnets(client *client.Client, defaultVpc *DefaultVPC) *DefaultVPCSubnets {
+	d := new(DefaultVPCSubnets)
 	d.Client = client
 	d.Dependencies.DefaultVPC = defaultVpc
 	return d
 }
 
-type DefaultVPCSubnet struct {
+type DefaultVPCSubnets struct {
 	Client       *client.Client
-	Resource     *types.Subnet
+	Resource     []*types.Subnet
 	Dependencies struct {
 		*DefaultVPC
 	}
 }
 
-func (d *DefaultVPCSubnet) Read(ctx context.Context) error {
+func (d *DefaultVPCSubnets) Read(ctx context.Context) error {
 	input := ec2.DescribeSubnetsInput{
 		Filters: []types.Filter{
 			{
 				Name:   aws.String("vpc-id"),
 				Values: []string{aws.ToString(d.Dependencies.DefaultVPC.Resource.VpcId)},
 			},
+			{
+				Name:   aws.String("default-for-az"),
+				Values: []string{"true"},
+			},
 		},
 	}
 
@@ -41,16 +45,17 @@ func (d *DefaultVPCSubnet) Read(ctx context.Context) error {
 		return err
 	}
 
-	if len(subnets.Subnets) < 1 {
-		return common.NotFoundError
-	}
-
+	d.Resource = nil
 	for _, subnet := range subnets.Subnets {
-		if aws.ToInt32(subnet.AvailableIpAddressCount) > 0 && aws.ToBool(subnet.MapPublicIpOnLaunch) {
-			d.Resource = &subnet
-			return nil
+		s := subnet
+		if aws.ToInt32(s.AvailableIpAddressCount) > 0 && aws.ToBool(s.MapPublicIpOnLaunch) {
+			d.Resource = append(d.Resource, &s)
 		}
 	}
 
-	return common.NotFoundError
+	if len(d.Resource) < 1 {
+		return common.NotFoundError
+	}
+
+	return nil
 }

task/aws/resources/resource_auto_scaling_group.go

@@ -5,6 +5,7 @@ import (
 	"errors"
 	"net"
 	"strconv"
+	"strings"
 	"time"
 
 	"github.com/aws/smithy-go"
@@ -20,13 +21,13 @@ import (
 	"terraform-provider-iterative/task/common"
 )
 
-func NewAutoScalingGroup(client *client.Client, identifier common.Identifier, subnet *DefaultVPCSubnet, launchTemplate *LaunchTemplate, parallelism *uint16, spot common.Spot) *AutoScalingGroup {
+func NewAutoScalingGroup(client *client.Client, identifier common.Identifier, subnet *DefaultVPCSubnets, launchTemplate *LaunchTemplate, parallelism *uint16, spot common.Spot) *AutoScalingGroup {
 	a := new(AutoScalingGroup)
 	a.Client = client
 	a.Identifier = identifier.Long()
 	a.Attributes.Parallelism = parallelism
 	a.Attributes.Spot = float64(spot)
-	a.Dependencies.DefaultVPCSubnet = subnet
+	a.Dependencies.DefaultVPCSubnets = subnet
 	a.Dependencies.LaunchTemplate = launchTemplate
 	return a
 }
@@ -42,7 +43,7 @@ type AutoScalingGroup struct {
 		Events      []common.Event
 	}
 	Dependencies struct {
-		*DefaultVPCSubnet
+		*DefaultVPCSubnets
 		*LaunchTemplate
 	}
 	Resource *types.AutoScalingGroup
@@ -59,6 +60,11 @@ func (a *AutoScalingGroup) Create(ctx context.Context) error {
 		onDemandPercentage = 0
 	}
 
+	var subnets []string
+	for _, subnet := range a.Dependencies.DefaultVPCSubnets.Resource {
+		subnets = append(subnets, aws.ToString(subnet.SubnetId))
+	}
+
 	input := autoscaling.CreateAutoScalingGroupInput{
 		AutoScalingGroupName: aws.String(a.Identifier),
 		DesiredCapacity:      aws.Int32(0),
@@ -78,7 +84,7 @@ func (a *AutoScalingGroup) Create(ctx context.Context) error {
 				},
 			},
 		},
-		VPCZoneIdentifier: a.Dependencies.DefaultVPCSubnet.Resource.SubnetId,
+		VPCZoneIdentifier: aws.String(strings.Join(subnets, ",")),
 	}
 
 	if _, err := a.Client.Services.AutoScaling.CreateAutoScalingGroup(ctx, &input); err != nil {

task/aws/task.go

@@ -26,7 +26,7 @@ func New(ctx context.Context, cloud common.Cloud, identifier common.Identifier,
 	t.DataSources.DefaultVPC = resources.NewDefaultVPC(
 		t.Client,
 	)
-	t.DataSources.DefaultVPCSubnet = resources.NewDefaultVPCSubnet(
+	t.DataSources.DefaultVPCSubnets = resources.NewDefaultVPCSubnets(
 		t.Client,
 		t.DataSources.DefaultVPC,
 	)
@@ -70,7 +70,7 @@ func New(ctx context.Context, cloud common.Cloud, identifier common.Identifier,
 	t.Resources.AutoScalingGroup = resources.NewAutoScalingGroup(
 		t.Client,
 		t.Identifier,
-		t.DataSources.DefaultVPCSubnet,
+		t.DataSources.DefaultVPCSubnets,
 		t.Resources.LaunchTemplate,
 		&t.Attributes.Parallelism,
 		t.Attributes.Spot,
@@ -84,7 +84,7 @@ type Task struct {
 	Attributes  common.Task
 	DataSources struct {
 		*resources.DefaultVPC
-		*resources.DefaultVPCSubnet
+		*resources.DefaultVPCSubnets
 		*resources.Image
 		*resources.Credentials
 		*resources.PermissionSet
@@ -108,8 +108,8 @@ func (t *Task) Create(ctx context.Context) error {
 	if err := t.DataSources.DefaultVPC.Read(ctx); err != nil {
 		return err
 	}
-	logrus.Info("[3/12] Importing DefaultVPCSubnet...")
-	if err := t.DataSources.DefaultVPCSubnet.Read(ctx); err != nil {
+	logrus.Info("[3/12] Importing DefaultVPCSubnets...")
+	if err := t.DataSources.DefaultVPCSubnets.Read(ctx); err != nil {
 		return err
 	}
 	logrus.Info("[4/12] Reading Image...")
@@ -163,8 +163,8 @@ func (t *Task) Read(ctx context.Context) error {
 	if err := t.DataSources.DefaultVPC.Read(ctx); err != nil {
 		return err
 	}
-	logrus.Info("[2/9] Reading DefaultVPCSubnet...")
-	if err := t.DataSources.DefaultVPCSubnet.Read(ctx); err != nil {
+	logrus.Info("[2/9] Reading DefaultVPCSubnets...")
+	if err := t.DataSources.DefaultVPCSubnets.Read(ctx); err != nil {
 		return err
 	}
 	logrus.Info("[3/9] Reading Image...")