Skip to content

Commit 55fdc91

Browse files
authored
Migrate string assertion tests to Contains/NotContains (#82)
1 parent 0074fa7 commit 55fdc91

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

iterative/resource_runner_test.go

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package iterative
22

33
import (
44
"encoding/base64"
5-
"strings"
65
"testing"
76

87
"github.com/stretchr/testify/assert"
@@ -14,31 +13,31 @@ func TestScript(t *testing.T) {
1413
data["ami"] = isAMIAvailable("aws", "us-east-1")
1514

1615
script, _ := renderScript(data)
17-
assert.Equal(t, strings.Contains(script, "sudo ubuntu-drivers autoinstall"), false)
16+
assert.NotContains(t, script, "sudo ubuntu-drivers autoinstall")
1817
})
1918

2019
t.Run("AWS unknown region should add the NVIDA drivers", func(t *testing.T) {
2120
data := make(map[string]interface{})
2221
data["ami"] = isAMIAvailable("aws", "us-east-99")
2322

2423
script, _ := renderScript(data)
25-
assert.Equal(t, strings.Contains(script, "sudo ubuntu-drivers autoinstall"), true)
24+
assert.Contains(t, script, "sudo ubuntu-drivers autoinstall")
2625
})
2726

2827
t.Run("Azure known region should add the NVIDA drivers", func(t *testing.T) {
2928
data := make(map[string]interface{})
3029
data["ami"] = isAMIAvailable("azure", "westus")
3130

3231
script, _ := renderScript(data)
33-
assert.Equal(t, strings.Contains(script, "sudo ubuntu-drivers autoinstall"), true)
32+
assert.Contains(t, script, "sudo ubuntu-drivers autoinstall")
3433
})
3534

3635
t.Run("Azure unknown region should add the NVIDA drivers", func(t *testing.T) {
3736
data := make(map[string]interface{})
3837
data["ami"] = isAMIAvailable("azure", "us-east-99")
3938

4039
script, _ := renderScript(data)
41-
assert.Equal(t, strings.Contains(script, "sudo ubuntu-drivers autoinstall"), true)
40+
assert.Contains(t, script, "sudo ubuntu-drivers autoinstall")
4241
})
4342

4443
t.Run("Runner Startup Script", func(t *testing.T) {
@@ -47,6 +46,6 @@ func TestScript(t *testing.T) {
4746
data["runner_startup_script"] = string(startupScript)
4847

4948
script, _ := renderScript(data)
50-
assert.Equal(t, strings.Contains(script, "echo \"hello world\"\necho \"bye world\""), true)
49+
assert.Contains(t, script, "echo \"hello world\"\necho \"bye world\"")
5150
})
5251
}

0 commit comments

Comments
 (0)