-
Notifications
You must be signed in to change notification settings - Fork 0
Description
Kontext
🧩 Analysis chain
Clean component replacement - verify prop support.
The replacement of v-btn
with base-text-button
preserves all props and behavior correctly. Ensure that BaseTextButton
supports the prepend-icon
, disabled
, active
, and data-test
attributes.
Run the following script to verify BaseTextButton implementation and prop support:
🏁 Script executed:
#!/bin/bash
# Description: Verify BaseTextButton supports required props
# Check BaseTextButton.vue implementation
cat wls-gui-wahllokalsystem/src/components/common/buttons/BaseTextButton.vue
Length of output: 267
Critical component incompatibility - BaseTextButton lacks required prop support.
Verification reveals that BaseTextButton
does NOT support the props being passed in BaseButtonSave.vue:
prepend-icon
— not exposed; icon will not renderdisabled
— not exposed; button cannot be disabledactive
— not exposed; active state won't applydata-test
— not exposed; test attribute missing
The component is a minimal wrapper without a script section to accept and forward these props. Either update BaseTextButton
to expose these attributes or revise the implementation in BaseButtonSave.vue
.
Originally posted by @coderabbitai[bot] in #2072 (comment)
Fragen
- sollten wir die Attribute die man bei den Komponenten setzen kann explizit definieren? Dies hätte den Vorteil dass Tools (Coderabbit, IDE) eine bessere Unterstützung geben könnten. Auch die Doku in Form von Storybook wird auf diese weise expliziter da keine zusätzliche Doku (Vuetify) für Komponente erforderlich ist. Der Nachteil ist der Mehraufwand.