tooling: replace protolock with buf breaking (#3101)

Author: howardjohn

Makefile.core.mk

@@ -22,7 +22,6 @@ all: gen
 
 repo_dir := .
 
-protolock = protolock
 annotations_prep = annotations_prep
 htmlproofer = htmlproofer
 
@@ -46,10 +45,13 @@ gen: \
 	generate-labels \
 	mirror-licenses \
 	tidy-go \
-	proto-commit
+	breaking
 
 gen-check: gen check-clean-repo
 
+breaking:
+	@./scripts/breaking.sh $(UPDATE_BRANCH)
+
 #####################
 # annotation/...
 #####################
@@ -84,19 +86,6 @@ generate-labels: $(labels_pb_go) $(labels_pb_doc)
 clean-labels:
 	@rm -fr $(labels_pb_go) $(labels_pb_doc)
 
-#####################
-# Protolock
-#####################
-
-proto-commit:
-	@$(protolock) commit
-
-proto-commit-force:
-	@$(protolock) commit --force
-
-proto-status:
-	@$(protolock) status
-
 #####################
 # Misc
 #####################
@@ -109,7 +98,7 @@ local-lint-protos:
 lint: lint-dockerfiles lint-scripts lint-yaml lint-helm lint-copyright-banner lint-go lint-python lint-markdown lint-sass lint-typescript lint-licenses local-lint-protos
  	@$(htmlproofer) . --url-swap "istio.io:preliminary.istio.io" --assume-extension --check-html --check-external-hash --check-opengraph --timeframe 2d --storage-dir $(repo_dir)/.htmlproofer --url-ignore "/localhost/"
 
-test:
+test: breaking
 	(pushd tests && go test -v ./...)
 
 fmt: format-python
@@ -118,7 +107,7 @@ fmt: format-python
 # CI System
 #####################
 
-presubmit: proto-commit lint test
+presubmit: lint test
 postsubmit: presubmit
 
 #####################

README.md

@@ -22,10 +22,6 @@ gen` will update the proto.lock file with new changes.
 
 ## Backwards Incompatible Changes
 
-If a PR tries to make backwards incompatible changes, it will be
-blocked by protolock. To force these changes in, install
-[protolock](https://github.com/nilslice/protolock) and run
-`protolock commit --force`.
-
-You must include a note in your PR that you had to force the
-protolock and why.
+If a PR tries to make backwards incompatible changes, it will be blocked by `buf breaking`.
+If there are legitimate reasons to make these breaking changes forever, the configuration in [`buf.yaml`](buf.yaml) can be changed.
+If it is a one-off case, the PR can be force approved skipping the test.

buf.yaml

@@ -2,6 +2,9 @@ version: v1
 build:
   excludes:
     - common-protos
+breaking:
+  use:
+  - WIRE_JSON
 lint:
   use:
     - BASIC