Skip to content

Commit e14257a

Browse files
add option to skip istio specific tags in trace spans (#3322)
* add option to skip istio specific tags in trace spans Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * move telemetry to boolean Signed-off-by: Rama Chavali <rama.rao@salesforce.com> --------- Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
1 parent 5ef47d3 commit e14257a

File tree

7 files changed

+744
-667
lines changed

7 files changed

+744
-667
lines changed

kubernetes/customresourcedefinitions.gen.yaml

Lines changed: 10 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

mesh/v1alpha1/istio.mesh.v1alpha1.pb.html

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

mesh/v1alpha1/proxy.pb.go

Lines changed: 505 additions & 489 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

mesh/v1alpha1/proxy.proto

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,8 +221,12 @@ message Tracing {
221221
// mode as `ISTIO_MUTUAL`.
222222
istio.networking.v1alpha3.ClientTLSSettings tls_settings = 8;
223223

224+
// Determines whether or not trace spans generated by Envoy will include Istio specific tags.
225+
// By default Istio specific tags are included in the trace spans.
226+
google.protobuf.BoolValue enable_istio_tags = 10;
227+
224228
// $hide_from_docs
225-
// Next available field number: 10
229+
// Next available field number: 11
226230

227231
}
228232

telemetry/v1alpha1/telemetry.pb.go

Lines changed: 193 additions & 177 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

telemetry/v1alpha1/telemetry.pb.html

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

telemetry/v1alpha1/telemetry.proto

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -410,6 +410,13 @@ message Tracing {
410410
// $hide_from_docs
411411
// +cue-gen:Telemetry:releaseChannel:extended
412412
google.protobuf.BoolValue use_request_id_for_trace_sampling = 6;
413+
414+
// Determines whether or not trace spans generated by Envoy will include Istio specific tags.
415+
// By default Istio specific tags are included in the trace spans.
416+
google.protobuf.BoolValue enable_istio_tags = 8;
417+
418+
// $hide_from_docs
419+
// Next available field number: 9
413420
}
414421

415422
// Used to bind Telemetry configuration to specific providers for

0 commit comments

Comments
 (0)