Skip to content

Commit da3290f

Browse files
committed
Add ambient mode caveats
1 parent 3203c6c commit da3290f

File tree

6 files changed

+15
-6
lines changed

6 files changed

+15
-6
lines changed

networking/v1alpha3/service_entry.pb.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/service_entry.pb.html

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/service_entry.proto

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -464,6 +464,9 @@ message ServiceEntry {
464464
// 1. subjectAltNames: In addition to verifying the SANs of the
465465
// service accounts associated with the pods of the service, the
466466
// SANs specified here will also be verified.
467+
//
468+
// **NOTE 3:** Wildcard hostnames are not support in ambient mode.
469+
//
467470
// +kubebuilder:validation:MinItems=1
468471
// +kubebuilder:validation:MaxItems=256
469472
// +protoc-gen-crd:list-value-validation:XValidation:message="hostname cannot be wildcard",rule="self != '*'"

networking/v1alpha3/sidecar.pb.go

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/sidecar.pb.html

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/sidecar.proto

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,9 @@ syntax = "proto3";
2121
// $aliases: [/docs/reference/config/networking/v1alpha3/sidecar]
2222

2323
// `Sidecar` describes the configuration of the sidecar proxy that mediates
24-
// inbound and outbound communication to the workload instance it is attached to. By
25-
// default, Istio will program all sidecar proxies in the mesh with the
24+
// inbound and outbound communication to the workload instance it is attached to.
25+
// `Sidecar` only applies to Sidecar mode.
26+
// By default, Istio will program all sidecar proxies in the mesh with the
2627
// necessary configuration required to reach every workload instance in the mesh, as
2728
// well as accept traffic on all the ports associated with the
2829
// workload. The `Sidecar` configuration provides a way to fine tune the set of

0 commit comments

Comments
 (0)