Skip to content

Commit a1abc53

Browse files
authored
Improve documentation for subjectAltNames (#3319)
1 parent 49f1d2b commit a1abc53

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

networking/v1alpha3/gateway.pb.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/gateway.pb.html

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/gateway.proto

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -393,12 +393,12 @@ message ServerTLSSettings {
393393
PASSTHROUGH = 0;
394394

395395
// Secure connections with standard TLS semantics. In this mode
396-
// client certificate is not requested during handshake.
396+
// client certificate is not requested during handshake.
397397
SIMPLE = 1;
398398

399399
// Secure connections to the downstream using mutual TLS by
400400
// presenting server certificates for authentication.
401-
// A client certificate will also be requested during the handshake and
401+
// A client certificate will also be requested during the handshake and
402402
// at least one valid certificate is required to be sent by the client.
403403
MUTUAL = 2;
404404

@@ -424,9 +424,9 @@ message ServerTLSSettings {
424424
ISTIO_MUTUAL = 4;
425425

426426
// Similar to MUTUAL mode, except that the client certificate
427-
// is optional. Unlike SIMPLE mode, A client certificate will
428-
// still be explicitly requested during handshake, but the client
429-
// is not required to send a certificate. If a client certificate
427+
// is optional. Unlike SIMPLE mode, A client certificate will
428+
// still be explicitly requested during handshake, but the client
429+
// is not required to send a certificate. If a client certificate
430430
// is presented, it will be validated. ca_certificates should
431431
// be specified for validating client certificates.
432432
OPTIONAL_MUTUAL = 5;
@@ -473,6 +473,7 @@ message ServerTLSSettings {
473473

474474
// A list of alternate names to verify the subject identity in the
475475
// certificate presented by the client.
476+
// Requires TLS mode to be set to `MUTUAL`.
476477
repeated string subject_alt_names = 6;
477478

478479
// An optional list of base64-encoded SHA-256 hashes of the SPKIs of

0 commit comments

Comments
 (0)