Skip to content

Commit 9fad1ae

Browse files
authored
proxy config: clarify concurrency docs (#3193)
Fixes #1783
1 parent f9846b4 commit 9fad1ae

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

mesh/v1alpha1/istio.mesh.v1alpha1.pb.html

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

mesh/v1alpha1/proxy.pb.go

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

mesh/v1alpha1/proxy.proto

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -456,9 +456,9 @@ message ProxyConfig {
456456
int32 stat_name_length = 15;
457457

458458
// The number of worker threads to run.
459-
// If unset, this will be automatically determined based on CPU requests/limits.
460-
// If set to 0, all cores on the machine will be used.
461-
// Default is 2 worker threads.
459+
// If unset, which is recommended, this will be automatically determined based on CPU requests/limits.
460+
// If set to 0, all cores on the machine will be used, ignoring CPU requests or limits. This can lead to major performance
461+
// issues if CPU limits are also set.
462462
google.protobuf.Int32Value concurrency = 16;
463463

464464
// Path to the proxy bootstrap template file

0 commit comments

Comments
 (0)