Skip to content

Commit 95b5260

Browse files
authored
remove hide_from_docs for http route mirrors (#2893)
1 parent 14a4abd commit 95b5260

File tree

6 files changed

+71
-49
lines changed

6 files changed

+71
-49
lines changed

kubernetes/customresourcedefinitions.gen.yaml

Lines changed: 8 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/virtual_service.pb.go

Lines changed: 0 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/virtual_service.pb.html

Lines changed: 63 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/virtual_service.proto

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -633,9 +633,6 @@ message HTTPRoute {
633633
// destination.
634634
Destination mirror = 9;
635635

636-
// $hide_from_docs
637-
// Hide this from doc until implemented.
638-
//
639636
// Specifies the destinations to mirror HTTP traffic in addition
640637
// to the original destination. Mirrored traffic is on a
641638
// best effort basis where the sidecar/gateway will not wait for the
@@ -2090,25 +2087,16 @@ message HTTPFaultInjection {
20902087
}
20912088
}
20922089

2093-
// $hide_from_docs
2094-
// Hide this from doc until implemented.
2095-
//
20962090
// HTTPMirrorPolicy can be used to specify the destinations to mirror HTTP traffic in addition
20972091
// to the original destination. Mirrored traffic is on a
20982092
// best effort basis where the sidecar/gateway will not wait for the
20992093
// mirrored destinations to respond before returning the response from the
21002094
// original destination. Statistics will be generated for the mirrored
21012095
// destination.
21022096
message HTTPMirrorPolicy {
2103-
// $hide_from_docs
2104-
// Hide this from doc until implemented.
2105-
//
21062097
// Destination specifies the target of the mirror operation.
21072098
Destination destination = 1 [(google.api.field_behavior) = REQUIRED];
21082099

2109-
// $hide_from_docs
2110-
// Hide this from doc until implemented.
2111-
//
21122100
// Percentage of the traffic to be mirrored by the `destination` field.
21132101
// If this field is absent, all the traffic (100%) will be mirrored.
21142102
// Max value is 100.

networking/v1beta1/virtual_service.pb.go

Lines changed: 0 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1beta1/virtual_service.proto

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -633,9 +633,6 @@ message HTTPRoute {
633633
// destination.
634634
Destination mirror = 9;
635635

636-
// $hide_from_docs
637-
// Hide this from doc until implemented.
638-
//
639636
// Specifies the destinations to mirror HTTP traffic in addition
640637
// to the original destination. Mirrored traffic is on a
641638
// best effort basis where the sidecar/gateway will not wait for the
@@ -2090,25 +2087,16 @@ message HTTPFaultInjection {
20902087
}
20912088
}
20922089

2093-
// $hide_from_docs
2094-
// Hide this from doc until implemented.
2095-
//
20962090
// HTTPMirrorPolicy can be used to specify the destinations to mirror HTTP traffic in addition
20972091
// to the original destination. Mirrored traffic is on a
20982092
// best effort basis where the sidecar/gateway will not wait for the
20992093
// mirrored destinations to respond before returning the response from the
21002094
// original destination. Statistics will be generated for the mirrored
21012095
// destination.
21022096
message HTTPMirrorPolicy {
2103-
// $hide_from_docs
2104-
// Hide this from doc until implemented.
2105-
//
21062097
// Destination specifies the target of the mirror operation.
21072098
Destination destination = 1 [(google.api.field_behavior) = REQUIRED];
21082099

2109-
// $hide_from_docs
2110-
// Hide this from doc until implemented.
2111-
//
21122100
// Percentage of the traffic to be mirrored by the `destination` field.
21132101
// If this field is absent, all the traffic (100%) will be mirrored.
21142102
// Max value is 100.

0 commit comments

Comments
 (0)