Skip to content

Commit 8b0251e

Browse files
authored
Update virtualservice HTTPRetry docs for the attempt field (#2919)
* Update virtualservice HTTPRetry docs for the `attempt` field * update files with docs
1 parent d292c26 commit 8b0251e

File tree

5 files changed

+10
-5
lines changed

5 files changed

+10
-5
lines changed

networking/v1alpha3/virtual_service.pb.go

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/virtual_service.pb.html

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/virtual_service.proto

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1793,7 +1793,8 @@ message HTTPRetry {
17931793
// between retries will be determined automatically (25ms+). When request
17941794
// `timeout` of the [HTTP route](https://istio.io/docs/reference/config/networking/virtual-service/#HTTPRoute)
17951795
// or `per_try_timeout` is configured, the actual number of retries attempted also depends on
1796-
// the specified request `timeout` and `per_try_timeout` values.
1796+
// the specified request `timeout` and `per_try_timeout` values. MUST BE >= 0. If `0`, retries will be disabled.
1797+
// The maximum possible number of requests made will be 1 + `attempts`.
17971798
int32 attempts = 1 [(google.api.field_behavior) = REQUIRED];
17981799

17991800
// Timeout per attempt for a given request, including the initial call and any retries. Format: 1h/1m/1s/1ms. MUST BE >=1ms.

networking/v1beta1/virtual_service.pb.go

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1beta1/virtual_service.proto

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1793,7 +1793,8 @@ message HTTPRetry {
17931793
// between retries will be determined automatically (25ms+). When request
17941794
// `timeout` of the [HTTP route](https://istio.io/docs/reference/config/networking/virtual-service/#HTTPRoute)
17951795
// or `per_try_timeout` is configured, the actual number of retries attempted also depends on
1796-
// the specified request `timeout` and `per_try_timeout` values.
1796+
// the specified request `timeout` and `per_try_timeout` values. MUST BE >= 0. If `0`, retries will be disabled.
1797+
// The maximum possible number of requests made will be 1 + `attempts`.
17971798
int32 attempts = 1 [(google.api.field_behavior) = REQUIRED];
17981799

17991800
// Timeout per attempt for a given request, including the initial call and any retries. Format: 1h/1m/1s/1ms. MUST BE >=1ms.

0 commit comments

Comments
 (0)