Skip to content

Commit 165508d

Browse files
Automator: update common-files@master in istio/api@master (#3411)
1 parent 6e7901d commit 165508d

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

common/.commonfiles.sha

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
ba7210ce85bf5b4ea2795fdf3cf66cc971360224
1+
1b8e05315fc4e40c5ac95ac4e828bda265f80e12

common/scripts/kind_provisioner.sh

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ set -x
3535
DEFAULT_KIND_IMAGE="gcr.io/istio-testing/kind-node:v1.32.0"
3636

3737
# the default kind cluster should be ipv4 if not otherwise specified
38-
IP_FAMILY="${IP_FAMILY:-ipv4}"
38+
KIND_IP_FAMILY="${KIND_IP_FAMILY:-ipv4}"
3939

4040
# COMMON_SCRIPTS contains the directory this file is in.
4141
COMMON_SCRIPTS=$(dirname "${BASH_SOURCE:-$0}")
@@ -147,7 +147,7 @@ function setup_kind_cluster_retry() {
147147
# 1. NAME: Name of the Kind cluster (optional)
148148
# 2. IMAGE: Node image used by KinD (optional)
149149
# 3. CONFIG: KinD cluster configuration YAML file. If not specified then DEFAULT_CLUSTER_YAML is used
150-
# 4. NOMETALBINSTALL: Dont install matllb if set.
150+
# 4. NOMETALBINSTALL: Dont install metalb if set.
151151
# This function returns 0 when everything goes well, or 1 otherwise
152152
# If Kind cluster was already created then it would be cleaned up in case of errors
153153
function setup_kind_cluster() {
@@ -186,7 +186,7 @@ function setup_kind_cluster() {
186186

187187
# Create KinD cluster
188188
if ! (yq eval "${CONFIG}" --expression ".networking.disableDefaultCNI = ${KIND_DISABLE_CNI}" \
189-
--expression ".networking.ipFamily = \"${IP_FAMILY}\"" | \
189+
--expression ".networking.ipFamily = \"${KIND_IP_FAMILY}\"" | \
190190
kind create cluster --name="${NAME}" -v4 --retain --image "${IMAGE}" ${KIND_WAIT_FLAG:+"$KIND_WAIT_FLAG"} --config -); then
191191
echo "Could not setup KinD environment. Something wrong with KinD setup. Exporting logs."
192192
return 9
@@ -230,7 +230,7 @@ function setup_kind_cluster() {
230230
# https://github.com/coredns/coredns/issues/2494#issuecomment-457215452
231231
# CoreDNS should handle those domains and answer with NXDOMAIN instead of SERVFAIL
232232
# otherwise pods stops trying to resolve the domain.
233-
if [ "${IP_FAMILY}" = "ipv6" ] || [ "${IP_FAMILY}" = "dual" ]; then
233+
if [ "${KIND_IP_FAMILY}" = "ipv6" ] || [ "${KIND_IP_FAMILY}" = "dual" ]; then
234234
# Get the current config
235235
original_coredns=$(kubectl get -oyaml -n=kube-system configmap/coredns)
236236
echo "Original CoreDNS config:"
@@ -267,14 +267,14 @@ function cleanup_kind_clusters() {
267267
# setup_kind_clusters sets up a given number of kind clusters with given topology
268268
# as specified in cluster topology configuration file.
269269
# 1. IMAGE = docker image used as node by KinD
270-
# 2. IP_FAMILY = either ipv4 or ipv6
270+
# 2. KIND_IP_FAMILY = either ipv4 or ipv6 or dual
271271
#
272272
# NOTE: Please call load_cluster_topology before calling this method as it expects
273273
# cluster topology information to be loaded in advance
274274
function setup_kind_clusters() {
275275
IMAGE="${1:-"${DEFAULT_KIND_IMAGE}"}"
276276
KUBECONFIG_DIR="${ARTIFACTS:-$(mktemp -d)}/kubeconfig"
277-
IP_FAMILY="${2:-ipv4}"
277+
KIND_IP_FAMILY="${2:-ipv4}"
278278

279279
check_default_cluster_yaml
280280

0 commit comments

Comments
 (0)