Skip to content

Commit 03360c1

Browse files
authored
Validation: remove CEL for PolicyTargetRef to allow vendor extensions (#3414)
* Validation: CEL adjusted to allow PolicyTargetReference to target gtwapi GatewayClass Signed-off-by: Ian Rudie <ian.rudie@solo.io> * adding releasenote Signed-off-by: Ian Rudie <ian.rudie@solo.io> * remove CEL validations for PolicyTargetRef to allow vendor extensions Signed-off-by: Ian Rudie <ian.rudie@solo.io> * remove centralized group/kind detail and move to where targetRef is used in resources Signed-off-by: Ian Rudie <ian.rudie@solo.io> --------- Signed-off-by: Ian Rudie <ian.rudie@solo.io>
1 parent daf0cd6 commit 03360c1

20 files changed

+43
-92
lines changed

extensions/v1alpha1/wasm.pb.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

extensions/v1alpha1/wasm.pb.html

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

extensions/v1alpha1/wasm.proto

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,9 @@ message WasmPlugin {
257257
//
258258
// Currently, the following resource attachment types are supported:
259259
// * `kind: Gateway` with `group: gateway.networking.k8s.io` in the same namespace.
260+
// * `kind: GatewayClass` with `group: gateway.networking.k8s.io` in the root namespace.
260261
// * `kind: Service` with `group: ""` or `group: "core"` in the same namespace. This type is only supported for waypoints.
262+
// * `kind: ServiceEntry` with `group: networking.istio.io` in the same namespace.
261263
//
262264
// If not set, the policy is applied as defined by the selector.
263265
// At most one of the selector and targetRefs can be set.

kubernetes/customresourcedefinitions.gen.yaml

Lines changed: 0 additions & 90 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/envoy_filter.pb.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/envoy_filter.pb.html

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/envoy_filter.proto

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -890,7 +890,9 @@ message EnvoyFilter {
890890
//
891891
// Currently, the following resource attachment types are supported:
892892
// * `kind: Gateway` with `group: gateway.networking.k8s.io` in the same namespace.
893+
// * `kind: GatewayClass` with `group: gateway.networking.k8s.io` in the root namespace.
893894
// * `kind: Service` with `""` in the same namespace. This type is only supported for waypoints.
895+
// * `kind: ServiceEntry` with `group: networking.istio.io` in the same namespace.
894896
//
895897
// If not set, the policy is applied as defined by the selector.
896898
// At most one of the selector and targetRefs can be set.

releasenotes/notes/3412.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
apiVersion: release-notes/v2
2+
kind: feature
3+
area: traffic-management
4+
issue:
5+
- https://github.com/istio/istio/issues/54696
6+
releaseNotes:
7+
- |
8+
**Removed** CEL validation of group/kind for PolicyTargetReference to enable vendor extensions

security/v1beta1/authorization_policy.pb.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

security/v1beta1/authorization_policy.pb.html

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)