From 2fbbff36c5cd27ade7125b08a73eb18497d931cc Mon Sep 17 00:00:00 2001 From: emap2 Date: Thu, 18 May 2017 09:22:46 +0200 Subject: [PATCH 1/2] Update package.json Package.json main has to be a string with only one element --- package.json | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/package.json b/package.json index 50fac9a..eba2230 100644 --- a/package.json +++ b/package.json @@ -2,10 +2,7 @@ "name": "isteven-angular-multiselect", "version": "v4.0.0", "description": "A multi select dropdown directive for AngularJS", - "main": [ - "isteven-multi-select.js", - "isteven-multi-select.css" - ], + "main":"isteven-multi-select.js", "repository": { "type": "git", "url": "https://github.com/isteven/angular-multi-select.git" From 968ae70e85f25ae3853ea5cbc344f4cce8d5d536 Mon Sep 17 00:00:00 2001 From: emap2 Date: Thu, 18 May 2017 09:26:30 +0200 Subject: [PATCH 2/2] Update isteven-multi-select.js Fix for ipad/iphone click-event bug. --- isteven-multi-select.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/isteven-multi-select.js b/isteven-multi-select.js index b5d3465..1fc190a 100644 --- a/isteven-multi-select.js +++ b/isteven-multi-select.js @@ -600,7 +600,7 @@ angular.module( 'isteven-multi-select', ['ng'] ).directive( 'istevenMultiSelect' var clickedEl = element.children()[0]; // Just to make sure.. had a bug where key events were recorded twice - angular.element( document ).off( 'click', $scope.externalClickListener ); + angular.element( document ).off( 'click touchstart', $scope.externalClickListener ); angular.element( document ).off( 'keydown', $scope.keyboardListener ); // The idea below was taken from another multi-select directive - https://github.com/amitava82/angular-multiselect @@ -611,7 +611,7 @@ angular.module( 'isteven-multi-select', ['ng'] ).directive( 'istevenMultiSelect' angular.element( checkBoxLayer ).removeClass( 'show' ); angular.element( clickedEl ).removeClass( 'buttonClicked' ); - angular.element( document ).off( 'click', $scope.externalClickListener ); + angular.element( document ).off( 'click touchstart', $scope.externalClickListener ); angular.element( document ).off( 'keydown', $scope.keyboardListener ); // clear the focused element; @@ -643,7 +643,7 @@ angular.module( 'isteven-multi-select', ['ng'] ).directive( 'istevenMultiSelect' // Attach change event listener on the input filter. // We need this because ng-change is apparently not an event listener. - angular.element( document ).on( 'click', $scope.externalClickListener ); + angular.element( document ).on( 'click touchstart', $scope.externalClickListener ); angular.element( document ).on( 'keydown', $scope.keyboardListener ); // to get the initial tab index, depending on how many helper elements we have. @@ -697,7 +697,7 @@ angular.module( 'isteven-multi-select', ['ng'] ).directive( 'istevenMultiSelect' angular.element( checkBoxLayer.previousSibling ).removeClass( 'buttonClicked' ); angular.element( checkBoxLayer ).removeClass( 'show' ); - angular.element( document ).off( 'click', $scope.externalClickListener ); + angular.element( document ).off( 'click touchstart', $scope.externalClickListener ); angular.element( document ).off( 'keydown', $scope.keyboardListener ); // close callback