From 25f7938dba96d9659c9b4204e9c096f691a8416b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?bruno=20zii=C3=AA?= Date: Sun, 4 Dec 2016 20:08:21 -0300 Subject: [PATCH 1/2] Fix removeClass bug When clicked out of container, the class *buttonClicked* was not being removed. --- isteven-multi-select.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/isteven-multi-select.js b/isteven-multi-select.js index b5d3465..2fa0e43 100644 --- a/isteven-multi-select.js +++ b/isteven-multi-select.js @@ -695,7 +695,7 @@ angular.module( 'isteven-multi-select', ['ng'] ).directive( 'istevenMultiSelect' } } - angular.element( checkBoxLayer.previousSibling ).removeClass( 'buttonClicked' ); + angular.element( clickedEl ).removeClass( 'buttonClicked' ); angular.element( checkBoxLayer ).removeClass( 'show' ); angular.element( document ).off( 'click', $scope.externalClickListener ); angular.element( document ).off( 'keydown', $scope.keyboardListener ); From 49d8bdce573266be79cf2fb21e0455ac984436fd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?bruno=20zii=C3=AA?= Date: Sun, 4 Dec 2016 20:26:16 -0300 Subject: [PATCH 2/2] change selector to parentNode --- isteven-multi-select.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/isteven-multi-select.js b/isteven-multi-select.js index 2fa0e43..a4cd9dc 100644 --- a/isteven-multi-select.js +++ b/isteven-multi-select.js @@ -695,7 +695,7 @@ angular.module( 'isteven-multi-select', ['ng'] ).directive( 'istevenMultiSelect' } } - angular.element( clickedEl ).removeClass( 'buttonClicked' ); + angular.element( checkBoxLayer.parentNode ).removeClass( 'buttonClicked' ); angular.element( checkBoxLayer ).removeClass( 'show' ); angular.element( document ).off( 'click', $scope.externalClickListener ); angular.element( document ).off( 'keydown', $scope.keyboardListener );