Skip to content

Commit 7889c89

Browse files
committed
Merge pull request #598 from tkruse/fix-bad-chars2
fix slanted quotes
2 parents 534dd00 + 765ebd6 commit 7889c89

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

CppCoreGuidelines.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2256,7 +2256,7 @@ Passing a shared smart pointer (e.g., `std::shared_ptr`) implies a run-time cost
22562256
// can only accept ints for which you are willing to share ownership
22572257
void g(shared_ptr<int>);
22582258

2259-
// doesnt change ownership, but requires a particular ownership of the caller
2259+
// doesn't change ownership, but requires a particular ownership of the caller
22602260
void h(const unique_ptr<int>&);
22612261

22622262
// accepts any int
@@ -11370,7 +11370,7 @@ If you are doing lock-free programming for performance, you need to check for re
1137011370
Instruction reordering (static and dynamic) makes it hard for us to think effectively at this level (especially if you use relaxed memory models).
1137111371
Experience, (semi)formal models and model checking can be useful.
1137211372
Testing - often to an extreme extent - is essential.
11373-
Dont fly too close to the wind.
11373+
"Don't fly too close to the wind."
1137411374

1137511375
##### Enforcement
1137611376

@@ -11388,10 +11388,10 @@ Become an expert before shipping lock-free code for others to use.
1138811388

1138911389
* Anthony Williams: C++ concurrency in action. Manning Publications.
1139011390
* Boehm, Adve, You Don't Know Jack About Shared Variables or Memory Models , Communications of the ACM, Feb 2012.
11391-
* Boehm, Threads Basics, HPL TR 2009-259.
11392-
* Adve, Boehm, Memory Models: A Case for Rethinking Parallel Languages and Hardware, Communications of the ACM, August 2010.
11393-
* Boehm, Adve, Foundations of the C++ Concurrency Memory Model, PLDI 08.
11394-
* Mark Batty, Scott Owens, Susmit Sarkar, Peter Sewell, and Tjark Weber, Mathematizing C++ Concurrency, POPL 2011.
11391+
* Boehm, "Threads Basics", HPL TR 2009-259.
11392+
* Adve, Boehm, "Memory Models: A Case for Rethinking Parallel Languages and Hardware", Communications of the ACM, August 2010.
11393+
* Boehm, Adve, "Foundations of the C++ Concurrency Memory Model", PLDI 08.
11394+
* Mark Batty, Scott Owens, Susmit Sarkar, Peter Sewell, and Tjark Weber, "Mathematizing C++ Concurrency", POPL 2011.
1139511395
* Damian Dechev, Peter Pirkelbauer, and Bjarne Stroustrup: Understanding and Effectively Preventing the ABA Problem in Descriptor-based Lock-free Designs. 13th IEEE Computer Society ISORC 2010 Symposium. May 2010.
1139611396
* Damian Dechev and Bjarne Stroustrup: Scalable Non-blocking Concurrent Objects for Mission Critical Code. ACM OOPSLA'09. October 2009
1139711397
* Damian Dechev, Peter Pirkelbauer, Nicolas Rouquette, and Bjarne Stroustrup: Semantically Enhanced Containers for Concurrent Real-Time Systems. Proc. 16th Annual IEEE International Conference and Workshop on the Engineering of Computer Based Systems (IEEE ECBS). April 2009.

scripts/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ check-badchars: $(SOURCEPATH) $(BUILD_DIR) Makefile
7575
rm -f $(BUILD_DIR)/CppCoreGuidelines.md.badchars
7676
# print file, add line numbers, grep for bad chars
7777
cat ../CppCoreGuidelines.md | nl -ba | grep -P '’|‘|”|“|¸|–|…|¦' > $(BUILD_DIR)/CppCoreGuidelines.md.badchars || true
78-
if [ -s $(BUILD_DIR)/CppCoreGuidelines.md.badchars ]; then echo 'Warning: Undesired chars (–’‘“”¸…¦) found:'; cat $(BUILD_DIR)/CppCoreGuidelines.md.badchars; false; fi;
78+
if [ -s $(BUILD_DIR)/CppCoreGuidelines.md.badchars ]; then echo 'Warning: Undesired chars (–’‘“”¸…¦) found, use straight quotes instead:'; cat $(BUILD_DIR)/CppCoreGuidelines.md.badchars; false; fi;
7979

8080

8181

0 commit comments

Comments
 (0)