[antispam] experimenting (WIP)

Author: GuillaumeDua

.github/workflows/scripts/antispam.js

@@ -57,44 +57,46 @@ module.exports = async ({ github, context, core }) => {
 
     const { data: user } = await github.rest.users.getByUsername({ username: author });
 
-    const was_author_account_recently_created = (() => {
-
-        const time_point = (() => {
-            let value = new Date();
-            value.setHours(value.getHours() - 2);
-            return value;
-        });
-        const create_at = new Date(user.created_at);
-
-        console.log(">>> was_author_account_recently_created: ", {
-            time_point: time_point,
-            create_at: create_at
-        });
-
-        return create_at <= time_point;
-    })();
-
-    const is_author_only_contribution_on_GH = (async () => {
-        // WARNING: Depending on the time of day, event latency can be anywhere from 30s to 6h. (source: https://octokit.github.io/rest.js/v21/)
-        const { data: events } = await github.rest.activity.listEventsForAuthenticatedUser({
-            username: author,
-            per_page: 1
-        });
-
-        console.log(">>> is_author_only_contribution_on_GH: ", {
-            username: author,
-            events_length: events.length === 0,
-            events: events
-        });
-
-        return events.length === 0;
-    })();
-
     const checks = [
-        new Check({ predicate: () => was_author_account_recently_created(),              reason: "Account is less than an hour old" }),
-        new Check({ predicate: () => is_author_only_contribution_on_GH(),                reason: "First contribution to any GitHub project" }),
         new Check({ predicate: () => user.followers === 0 && user.following === 0,       reason: "Author has no relationships" }),
         new Check({ predicate: () => user.public_repos === 0 && user.public_gists === 0, reason: "Author has no public reop/gist" }),
+        new Check({
+            predicate: () => {
+
+                const time_point = (() => {
+                    let value = new Date();
+                    value.setHours(value.getHours() - 2);
+                    return value;
+                });
+                const create_at = new Date(user.created_at);
+        
+                console.log(">>> was_author_account_recently_created: ", {
+                    time_point: time_point,
+                    create_at: create_at
+                });
+        
+                return create_at <= time_point;
+            },
+            reason: "Account is less than an hour old"
+        }),
+        new Check({
+            predicate: async () => {
+                // WARNING: Depending on the time of day, event latency can be anywhere from 30s to 6h. (source: https://octokit.github.io/rest.js/v21/)
+                const { data: events } = await github.rest.activity.listEventsForAuthenticatedUser({
+                    username: author,
+                    per_page: 1
+                });
+        
+                console.log(">>> is_author_only_contribution_on_GH: ", {
+                    username: author,
+                    events_length: events.length === 0,
+                    events: events
+                });
+        
+                return events.length === 0;
+            },
+            reason: "First contribution to any GitHub project"
+        }),
     ];
 
     // IDEA: use weight instead of booleans