Skip to content

Commit 203ac47

Browse files
lumurillossheorey
andauthored
Fix SPLAT IO tests in Windows (#7213)
* Add binary mode to SPLAT read method * Fix code style * Fix docs (cmake<4.0), fix style --------- Co-authored-by: Sameer Sheorey <sameer.sheorey@intel.com>
1 parent bfca3ca commit 203ac47

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

cpp/open3d/t/io/file_format/FileSPLAT.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ bool ReadPointCloudFromSPLAT(const std::string &filename,
8888
try {
8989
// Open the file
9090
utility::filesystem::CFile file;
91-
if (!file.Open(filename, "r")) {
91+
if (!file.Open(filename, "rb")) {
9292
utility::LogWarning("Read SPLAT failed: unable to open file: {}",
9393
filename);
9494
return false;

util/ci_utils.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ install_python_dependencies() {
7676
fi
7777
if [ "$BUILD_PYTORCH_OPS" == "ON" ]; then # ML/requirements-torch.txt
7878
if [[ "$OSTYPE" == "linux-gnu"* && "$BUILD_SYCL_MODULE" == "OFF" ]]; then
79-
python -m pip install -U "${TORCH_GLNX}" -f "$TORCH_REPO_URL"
79+
python -m pip install -U "${TORCH_GLNX}" -f "$TORCH_REPO_URL"
8080
python -m pip install tensorboard
8181
elif [[ "$OSTYPE" == "linux-gnu"* && "$BUILD_SYCL_MODULE" == "ON" ]]; then
8282
python -m pip install -U "${TORCH_GLNX}.cxx11.abi" -i "$TORCH_CXX11_URL"
@@ -356,7 +356,7 @@ install_docs_dependencies() {
356356
command -v python
357357
python -V
358358
python -m pip install -U -q "pip==$PIP_VER"
359-
which cmake || python -m pip install -U -q cmake
359+
which cmake || python -m pip install -U -q "cmake<4.0"
360360
python -m pip install -U -q -r "${OPEN3D_SOURCE_ROOT}/python/requirements_build.txt"
361361
if [[ -d "$1" ]]; then
362362
OPEN3D_ML_ROOT="$1"

0 commit comments

Comments
 (0)