You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
corrected pairing in SSD head of pointpillars (#602)
Accordiing to the PointPillars paper, "A positive match is either the
highest with a ground truth box, or above the positive match threshold".
While the latter point is implemented correctly, there's a minor mistake
in the implementation of the first point. The original code only updates
the bool array _pos_idx_ without changing the matched target to the
correct ground truth index. This could lead to ground truth box without
a valid match in the end.
When I corrected the SSD matching, I also referred to this
implementation of SSD:
https://github.com/amdegroot/ssd.pytorch/blob/5b0b77faa955c1917b0c710d770739ba8fbff9b7/layers/box_utils.py#L106
<!-- Reviewable:start -->
- - -
This change is [<img src="https://reviewable.io/review_button.svg"
height="34" align="absmiddle"
alt="Reviewable"/>](https://reviewable.io/reviews/isl-org/Open3D-ML/602)
<!-- Reviewable:end -->
Co-authored-by: Benjamin Ummenhofer <benjaminum@gmail.com>
0 commit comments