Skip to content

Commit 02d79b9

Browse files
Fixes carb subscription API for gamepad device (#2173)
# Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. Fixes # SE2/3 gamepad that calling wrong omniverse API, [https://docs.omniverse.nvidia.com/dev-guide/latest/programmer_ref/input-devices/gamepad.html#unsubscribing-the-gamepad-event-handler](url) ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Signed-off-by: AlvinC <alvincny529@gmail.com>
1 parent 8936a5a commit 02d79b9

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

CONTRIBUTORS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ Guidelines for modifications:
7777
* Michael Noseworthy
7878
* Muhong Guo
7979
* Nicola Loi
80+
* Nuoyan Chen (Alvin)
8081
* Nuralem Abizov
8182
* Ori Gadot
8283
* Oyindamola Omotuyi

source/isaaclab/isaaclab/devices/gamepad/se2_gamepad.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ def __init__(
8787

8888
def __del__(self):
8989
"""Unsubscribe from gamepad events."""
90-
self._input.unsubscribe_from_gamepad_events(self._gamepad, self._gamepad_sub)
90+
self._input.unsubscribe_to_gamepad_events(self._gamepad, self._gamepad_sub)
9191
self._gamepad_sub = None
9292

9393
def __str__(self) -> str:

source/isaaclab/isaaclab/devices/gamepad/se3_gamepad.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ def __init__(self, pos_sensitivity: float = 1.0, rot_sensitivity: float = 1.6, d
8888

8989
def __del__(self):
9090
"""Unsubscribe from gamepad events."""
91-
self._input.unsubscribe_from_gamepad_events(self._gamepad, self._gamepad_sub)
91+
self._input.unsubscribe_to_gamepad_events(self._gamepad, self._gamepad_sub)
9292
self._gamepad_sub = None
9393

9494
def __str__(self) -> str:

0 commit comments

Comments
 (0)