Skip to content

Doesn't work when with virtualbox shared volumes #28

@Stebalien

Description

@Stebalien

Basically, we try to sync a directory, windows fails with "invalid argument" (windows doesn't support syncing directories) and vbox forwards this error.

We actually have a check to avoid syncing directories on windows. Unfortunately... in this case, we think we're on Linux. I believe the correct fix is to detect that the error is an "invalid argument" error and ignore it (we can't sync anyways, nothing really failed).


Edit: It turns out that vboxsf just doesn't support fsync on directories at all. Really, we probably should just be ignoring fsync errors on directories entirely (possibly logging them?). There's not much we can do anyways.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions