[reward] remove check new start epoch

Author: dustinxie

action/protocol/rewarding/protocol.go

@@ -143,12 +143,7 @@ func (p *Protocol) setFoundationBonusExtension(ctx context.Context, sm protocol.
 
 	rp := rolldpos.MustGetProtocol(protocol.MustGetRegistry(ctx))
 	blkCtx := protocol.MustGetBlockCtx(ctx)
-	newStartEpoch := rp.GetEpochNum(blkCtx.BlockHeight)
-	newLastEpoch := newStartEpoch + 8760
-
-	if newStartEpoch < p.cfg.FoundationBonusP2StartEpoch {
-		return errInvalidEpoch
-	}
+	newLastEpoch := rp.GetEpochNum(blkCtx.BlockHeight) + 8760
 
 	if a.foundationBonusLastEpoch < p.cfg.FoundationBonusP2EndEpoch {
 		a.foundationBonusLastEpoch = p.cfg.FoundationBonusP2EndEpoch

action/protocol/rewarding/protocol_test.go

@@ -568,11 +568,10 @@ func TestMigrateValue(t *testing.T) {
 
 		for _, v := range []struct {
 			height, lastEpoch uint64
-			err               error
 		}{
-			{g.GreenlandBlockHeight, a1.foundationBonusLastEpoch, nil},
-			{1641601, a1.foundationBonusLastEpoch, errInvalidEpoch},
-			{g.KamchatkaBlockHeight, 47796, nil},
+			{g.GreenlandBlockHeight, a1.foundationBonusLastEpoch},
+			{1641601, g.FoundationBonusP2EndEpoch},
+			{g.KamchatkaBlockHeight, 47796},
 		} {
 			fCtx := ctx
 			if v.height == 1641601 {
@@ -585,7 +584,7 @@ func TestMigrateValue(t *testing.T) {
 			blkCtx := protocol.MustGetBlockCtx(ctx)
 			blkCtx.BlockHeight = v.height
 			fCtx = protocol.WithBlockCtx(fCtx, blkCtx)
-			r.Equal(v.err, p.CreatePreStates(fCtx, sm))
+			r.NoError(p.CreatePreStates(fCtx, sm))
 
 			// verify v1 is deleted
 			_, err = p.stateV1(sm, adminKey, &a)