Add tests for iotc cli

Author: Vedaad-Shakib

cli/iotc/cmd/balance.go

@@ -21,18 +21,18 @@ var balanceCmd = &cobra.Command{
 	Long:  `Returns the current balance of given address.`,
 	Args:  cobra.ExactArgs(1),
 	Run: func(cmd *cobra.Command, args []string) {
-		balance(args)
+		fmt.Println(balance(args))
 	},
 }
 
-func balance(args []string) {
+func balance(args []string) string {
 	client, _ := getClientAndCfg()
 	balance, err := client.GetAddressBalance(args[0])
 	if err != nil {
 		logger.Error().Err(err).Msgf("cannot get balance for address %s", args[0])
-		return
+		return ""
 	}
-	fmt.Printf("Address %s balance: %d\n", args[0], balance)
+	return fmt.Sprintf("Address %s balance: %d", args[0], balance)
 }
 
 func init() {

cli/iotc/cmd/details.go

@@ -21,19 +21,19 @@ var detailsCmd = &cobra.Command{
 	Long:  `Returns the details of given account, namely the balance and the nonce.`,
 	Args:  cobra.ExactArgs(1),
 	Run: func(cmd *cobra.Command, args []string) {
-		details(args)
+		fmt.Println(details(args))
 	},
 }
 
-func details(args []string) {
+func details(args []string) string {
 	client, _ := getClientAndCfg()
 	det, err := client.GetAddressDetails(args[0])
 	if err != nil {
 		logger.Error().Err(err).Msgf("cannot get details for address %s", args[0])
-		return
+		return ""
 	}
-	fmt.Printf("Address %s nonce: %d\n", args[0], det.Nonce)
-	fmt.Printf("Address %s balance: %d\n", args[0], det.TotalBalance)
+	return fmt.Sprintf("Address %s nonce: %d\n", args[0], det.Nonce) +
+		fmt.Sprintf("Address %s balance: %d", args[0], det.TotalBalance)
 }
 
 func init() {

cli/iotc/cmd/height.go

@@ -21,17 +21,18 @@ var heightCmd = &cobra.Command{
 	Long:  `Returns the current height of the blockchain.`,
 	Args:  cobra.ExactArgs(0),
 	Run: func(cmd *cobra.Command, args []string) {
-		height()
+		fmt.Println(height())
 	},
 }
 
-func height() {
+func height() string {
 	client, _ := getClientAndCfg()
 	tip, err := client.GetBlockchainHeight()
 	if err != nil {
 		logger.Error().Err(err).Msg("cannot get blockchain height")
+		return ""
 	}
-	fmt.Printf("blockchain height: %d\n", tip)
+	return fmt.Sprintf("blockchain height: %d", tip)
 }
 
 func init() {

cli/iotc/cmd/iotc_test.go

@@ -0,0 +1,35 @@
+package cmd
+
+import (
+	"strings"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+
+	"github.com/iotexproject/iotex-core/config"
+	"github.com/iotexproject/iotex-core/explorer"
+)
+
+var configFile = "../../../e2etest/config_local_delegate.yaml"
+
+func Test_All(t *testing.T) {
+	cfg, err := config.LoadConfigWithPath(configFile)
+	require.Nil(t, err)
+	httpPort := cfg.Explorer.Addr
+	explorer.StartJSONServer(nil, nil, true, httpPort, 0)
+
+	s := strings.Split(self(), " ")
+	addr := s[len(s)-1]
+
+	assert.Equal(t, "io1qyqsyqcy8uhx9jtdc2xp5wx7nxyq3xf4c3jmxknzkuej8y", addr)
+	assert.NotEqual(t, 0, height()) // height is random each time
+
+	limit = 10
+	tr := transfers([]string{addr, "10"})
+	assert.Equal(t, 9, strings.Count(tr, "\n"))
+
+	det := details([]string{addr})
+	assert.Equal(t, 1, strings.Count(det, "\n"))
+	assert.NotEqual(t, "", balance([]string{addr})) // no real way to test this because balance returned is random
+}

cli/iotc/cmd/root.go

@@ -20,7 +20,7 @@ import (
 )
 
 const (
-	yamlPath  = "/src/github.com/iotexproject/iotex-core/e2etests/config_local_delegate.yaml"
+	yamlPath  = "/src/github.com/iotexproject/iotex-core/e2etest/config_local_delegate.yaml"
 	localhost = "http://127.0.0.1:"
 )
 

cli/iotc/cmd/self.go

@@ -21,14 +21,14 @@ var selfCmd = &cobra.Command{
 	Short: "Returns this node's address",
 	Long:  `Returns this node's address`,
 	Run: func(cmd *cobra.Command, args []string) {
-		self()
+		fmt.Println(self())
 	},
 }
 
-func self() {
+func self() string {
 	_, cfg := getClientAndCfg()
 	rawAddr := address(cfg.Chain.ProducerPubKey)
-	fmt.Printf("this node's address is %s\n", rawAddr)
+	return fmt.Sprintf("this node's address is %s", rawAddr)
 }
 
 func address(pubkey string) string {

cli/iotc/cmd/transfers.go

@@ -23,20 +23,22 @@ var transfersCmd = &cobra.Command{
 	Long:  `Returns the transfers associated with a given address`,
 	Args:  cobra.ExactArgs(1),
 	Run: func(cmd *cobra.Command, args []string) {
-		transfers(args)
+		fmt.Println(transfers(args))
 	},
 }
 
-func transfers(args []string) {
+func transfers(args []string) string {
 	client, _ := getClientAndCfg()
 	transfers, err := client.GetTransfersByAddress(args[0], 0, int64(limit))
 	if err != nil {
 		logger.Error().Err(err).Msgf("cannot get transfers for address %s", args[0])
-		return
+		return ""
 	}
+	var res string
 	for _, t := range transfers {
-		fmt.Printf("%+v\n", t)
+		res += fmt.Sprintf("%+v\n", t)
 	}
+	return res[:len(res)-1] // get rid of the extra \n at the end
 }
 
 func init() {

server/itx/itxserver.go

@@ -36,7 +36,7 @@ type Server struct {
 // NewServer creates a new server
 func NewServer(cfg config.Config) *Server {
 	// create StateFactory
-	sf, err := state.NewFactoryFromTrieDBPath(cfg.Chain.TrieDBPath)
+	sf, err := state.NewFactoryFromTrieDBPath(cfg.Chain.TrieDBPath, false)
 	if err != nil {
 		logger.Error().Err(err).Msg("Failed to create statefactory")
 		return nil

simulator/consensus_sim_server.go

@@ -101,7 +101,7 @@ func (s *server) Init(in *pb.InitRequest, stream pb.Simulator_InitServer) error
 		// set chain database path
 		cfg.Chain.ChainDBPath = "./chain" + strconv.Itoa(i) + ".db"
 
-		sf, _ := state.NewFactoryFromTrieDBPath(cfg.Chain.TrieDBPath)
+		sf, _ := state.NewFactoryFromTrieDBPath(cfg.Chain.TrieDBPath, false)
 		bc := blockchain.CreateBlockchain(cfg, sf)
 
 		if i >= int(in.NFS+in.NHonest) { // is byzantine node

state/factory.go

@@ -89,12 +89,12 @@ func NewFactory(tr trie.Trie) Factory {
 }
 
 // NewFactoryFromTrieDBPath creates a new stateFactory from give trie db path.
-func NewFactoryFromTrieDBPath(dbPath string) (Factory, error) {
+func NewFactoryFromTrieDBPath(dbPath string, inMem bool) (Factory, error) {
 	if len(dbPath) == 0 {
 		// TODO not return error here is a hack
 		return nil, nil
 	}
-	tr, err := trie.NewTrie(dbPath, false)
+	tr, err := trie.NewTrie(dbPath, inMem)
 	if err != nil {
 		return nil, err
 	}