introduce producer private key range and using random key if inactive (#4662)

---------

Co-authored-by: Chen Chen <chen1233216@hotmail.com>

Author: CoderZhi

blockchain/config.go

@@ -8,6 +8,7 @@ package blockchain
 import (
 	"crypto/ecdsa"
 	"os"
+	"strconv"
 	"strings"
 	"time"
 
@@ -44,6 +45,7 @@ type (
 		Address                    string           `yaml:"address"`
 		ProducerPrivKey            string           `yaml:"producerPrivKey"`
 		ProducerPrivKeySchema      string           `yaml:"producerPrivKeySchema"`
+		ProducerPrivKeyRange       string           `yaml:"producerPrivKeyRange"`
 		SignatureScheme            []string         `yaml:"signatureScheme"`
 		EmptyGenesis               bool             `yaml:"emptyGenesis"`
 		GravityChainDB             db.Config        `yaml:"gravityChainDB"`
@@ -104,7 +106,7 @@ var (
 		ID:                         1,
 		EVMNetworkID:               4689,
 		Address:                    "",
-		ProducerPrivKey:            generateRandomKey(SigP256k1),
+		ProducerPrivKey:            GenerateRandomKey(SigP256k1),
 		SignatureScheme:            []string{SigP256k1},
 		EmptyGenesis:               false,
 		GravityChainDB:             db.Config{DbPath: "/var/data/poll.db", NumRetries: 10},
@@ -169,7 +171,35 @@ func (cfg *Config) ProducerPrivateKeys() []crypto.PrivateKey {
 		}
 		privateKeys = append(privateKeys, sk)
 	}
-	return privateKeys
+
+	if cfg.ProducerPrivKeyRange == "" {
+		return privateKeys
+	}
+	// Expecting format "[$start:$end]"
+	r := strings.Trim(cfg.ProducerPrivKeyRange, "[]")
+	parts := strings.Split(r, ":")
+	if len(parts) != 2 {
+		log.L().Panic("invalid format", zap.String("ProducerPrivKeyRange", cfg.ProducerPrivKeyRange))
+	}
+	start, end := 0, len(privateKeys)
+	var err error
+	if parts[0] != "" {
+		start, err = strconv.Atoi(parts[0])
+		if err != nil {
+			log.L().Panic("invalid start", zap.String("start", parts[0]), zap.Error(err))
+		}
+	}
+	if parts[1] != "" {
+		end, err = strconv.Atoi(parts[1])
+		if err != nil {
+			log.L().Panic("invalid end", zap.String("end", parts[1]), zap.Error(err))
+		}
+	}
+	if start < 0 || end > len(privateKeys) || start > end {
+		log.L().Panic("ProducerPrivKeyRange out of bounds", zap.Int("start", start), zap.Int("end", end), zap.Int("len", len(privateKeys)))
+	}
+
+	return privateKeys[start:end]
 }
 
 // SetProducerPrivKey set producer privKey by PrivKeyConfigFile info
@@ -203,7 +233,8 @@ func (cfg *Config) SetProducerPrivKey() error {
 	return nil
 }
 
-func generateRandomKey(scheme string) string {
+// GenerateRandomKey generates a random private key based on the signature scheme
+func GenerateRandomKey(scheme string) string {
 	// generate a random key
 	switch scheme {
 	case SigP256k1:

blockchain/config_test.go

@@ -6,6 +6,7 @@
 package blockchain
 
 import (
+	"strings"
 	"testing"
 
 	"github.com/iotexproject/go-pkgs/crypto"
@@ -33,3 +34,79 @@ func TestWhitelist(t *testing.T) {
 	r.Equal(sk, cfg.ProducerPrivateKeys()[0])
 	r.Equal(sk.PublicKey().Address().String(), cfg.ProducerAddress()[0].String())
 }
+
+func TestProducerPrivateKeys_RangeParsing(t *testing.T) {
+	r := require.New(t)
+	cfg := DefaultConfig
+	genKeys := func(size int) string {
+		var privKeyStrs []string
+		for i := 0; i < size; i++ {
+			sk, err := crypto.GenerateKey()
+			r.NoError(err)
+			privKeyStrs = append(privKeyStrs, sk.HexString())
+		}
+		return strings.Join(privKeyStrs, ",")
+	}
+
+	getKeys := func(privKey, privKeyRange string) (keys []crypto.PrivateKey, panicked bool) {
+		cfg.ProducerPrivKey = privKey
+		cfg.ProducerPrivKeyRange = privKeyRange
+		defer func() {
+			if r := recover(); r != nil {
+				panicked = true
+			}
+		}()
+		keys = cfg.ProducerPrivateKeys()
+		return
+	}
+
+	privKeys := genKeys(5)
+	keys, panicked := getKeys(privKeys, "")
+	r.False(panicked)
+	r.Len(keys, 5)
+
+	keys, panicked = getKeys(privKeys, "[:]")
+	r.False(panicked)
+	r.Len(keys, 5)
+
+	keys, panicked = getKeys(privKeys, "[0:0]")
+	r.False(panicked)
+	r.Len(keys, 0)
+
+	keys, panicked = getKeys(privKeys, "[0:1]")
+	r.False(panicked)
+	r.Len(keys, 1)
+
+	keys, panicked = getKeys(privKeys, "[1:3]")
+	r.False(panicked)
+	r.Len(keys, 2)
+
+	keys, panicked = getKeys(privKeys, "[3:5]")
+	r.False(panicked)
+	r.Len(keys, 2)
+
+	keys, panicked = getKeys(privKeys, "[5:]")
+	r.False(panicked)
+	r.Len(keys, 0)
+
+	keys, panicked = getKeys(privKeys, "[:5]")
+	r.False(panicked)
+	r.Len(keys, 5)
+
+	keys, panicked = getKeys(privKeys, "[2:]")
+	r.False(panicked)
+	r.Len(keys, 3)
+
+	_, panicked = getKeys(privKeys, "[invalid]")
+	r.True(panicked)
+
+	_, panicked = getKeys(privKeys, "[-1:1]")
+	r.True(panicked)
+
+	_, panicked = getKeys(privKeys, "[2:1]")
+	r.True(panicked)
+	_, panicked = getKeys(privKeys, "[1:6]")
+	r.True(panicked)
+	_, panicked = getKeys(privKeys, "[1:5:7]")
+	r.True(panicked)
+}

config/config.go

@@ -173,7 +173,15 @@ func New(configPaths []string, _plugins []string, validates ...Validate) (Config
 
 	// set network master key to private key
 	if cfg.Network.MasterKey == "" {
-		cfg.Network.MasterKey = cfg.Chain.ProducerPrivKey
+		if cfg.System.Active {
+			pks := cfg.Chain.ProducerPrivateKeys()
+			if len(pks) > 0 {
+				cfg.Network.MasterKey = pks[0].HexString()
+			}
+		}
+		if cfg.Network.MasterKey == "" {
+			cfg.Network.MasterKey = blockchain.GenerateRandomKey(blockchain.SigP256k1)
+		}
 	}
 
 	// set plugins