Retry upon 404 and exit if always 404 #207 (#233)

* Changed only description because default of autoupgrade is set to N

* Retry upon 404 and exit if always 404 #207

* Retry upon 404 and exit if always 404 #207 - improved reliability of downloads

* Retry upon 404 and exit if always 404 #207 - improved reliability of downloads

* New function for download

Co-authored-by: Ireneusz Makowski <Ireneusz.Makowski@3ds.com>

Author: irek-makowski

scripts/setup_fullnode.sh

@@ -116,6 +116,22 @@ function deleteOldFile() {
     fi
 }
 
+function downloadFile()
+{
+    echo "Downloading file: $1"
+    curl -Ss --connect-timeout 10 \
+        --max-time 10 \
+        --retry 10 \
+        --retry-delay 0 \
+        --retry-max-time 180 \
+        $1 > $2
+    response=$?
+    if test "$response" != "0"; then
+        echo -e "${RED} Download of configuration failed with following: $response"
+        exit 1
+    fi
+}
+
 function preDockerCompose() {
     # set monitor home
     IOTEX_MONITOR_HOME=$IOTEX_HOME/monitor
@@ -124,15 +140,15 @@ function preDockerCompose() {
 
     export IOTEX_HOME IOTEX_MONITOR_HOME IOTEX_IMAGE
 
-    curl -Ss https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/master/monitor/docker-compose.yml.gateway > $IOTEX_MONITOR_HOME/docker-compose.yml.gateway
-    curl -Ss https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/master/monitor/docker-compose.yml > $IOTEX_MONITOR_HOME/docker-compose.yml.default
-    curl -Ss https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/master/monitor/.env > $IOTEX_MONITOR_HOME/.env
+    downloadFile "https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/master/monitor/docker-compose.yml.gateway" "$IOTEX_MONITOR_HOME/docker-compose.yml.gateway"
+    downloadFile "https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/master/monitor/docker-compose.yml" "$IOTEX_MONITOR_HOME/docker-compose.yml.default"
+    downloadFile "https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/master/monitor/.env" "$IOTEX_MONITOR_HOME/.env"
 }
 
 function enableMonitor() {
     echo "Download config files for monitor"
-    curl -Ss https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/master/monitor/prometheus.yml > $IOTEX_MONITOR_HOME/prometheus.yml
-    curl -Ss https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/master/monitor/alert.rules > $IOTEX_MONITOR_HOME/alert.rules
+    downloadFile "https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/master/monitor/prometheus.yml" "$IOTEX_MONITOR_HOME/prometheus.yml"
+    downloadFile "https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/master/monitor/alert.rules" "$IOTEX_MONITOR_HOME/alert.rules"
 }
 
 function checkPrivateKey() {
@@ -215,13 +231,13 @@ function determinPrivKey() {
 
 function downloadConfig() {
     echo "download new config"
-    curl -Ss https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/${version}/config_${env}.yaml > $IOTEX_HOME/etc/config.yaml
-    curl -Ss https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/${version}/genesis_${env}.yaml > $IOTEX_HOME/etc/genesis.yaml
+    downloadFile "https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/${version}/config_${env}.yaml" "$IOTEX_HOME/etc/config.yaml"
+    downloadFile "https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/${version}/genesis_${env}.yaml" "$IOTEX_HOME/etc/genesis.yaml"
 
     #Download patch file
     if [ "${_ENV_}X" = "mainnetX" ];then
         echo -e "Downloading the patch file"
-        curl https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/${version}/trie.db.patch > $IOTEX_HOME/data/trie.db.patch
+        downloadFile "https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/${version}/trie.db.patch" "$IOTEX_HOME/data/trie.db.patch"
     fi
 
     SED_IS_GNU=0
@@ -340,12 +356,12 @@ function startAutoUpdate() {
     # Download auto-update command
     mkdir -p $IOTEX_HOME/bin
     if [ "$(uname)"X = "Darwin"X ];then
-        curl -Ss https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/master/tools/auto-update/auto-update_darwin-amd64 > $IOTEX_HOME/bin/auto-update || exit 1
+        downloadFile "https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/master/tools/auto-update/auto-update_darwin-amd64" "$IOTEX_HOME/bin/auto-update" || exit 1
     else
-        curl -Ss https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/master/tools/auto-update/auto-update_linux-amd64 > $IOTEX_HOME/bin/auto-update || exit 1
+        downloadFile "https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/master/tools/auto-update/auto-update_linux-amd64" "$IOTEX_HOME/bin/auto-update" || exit 1
     fi
 
-    curl -Ss https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/master/scripts/update_silence.sh > $IOTEX_HOME/bin/update_silence.sh || exit 1
+    downloadFile "https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/master/scripts/update_silence.sh" "$IOTEX_HOME/bin/update_silence.sh" || exit 1
     chmod +x $IOTEX_HOME/bin/auto-update $IOTEX_HOME/bin/update_silence.sh
 
     # Run background

scripts/update_silence.sh

@@ -86,8 +86,31 @@ function downloadConfig() {
     #curl -LSs https://t.iotex.me/${env}-data-latest > $IOTEX_HOME/data.tar.gz
     #cd ${IOTEX_HOME} && tar -xzf data.tar.gz
     echo "download new config"
-    curl -Ss https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/${version}/config_${_ENV_}.yaml > $IOTEX_HOME/etc/config.yaml
-    curl -Ss https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/${version}/genesis_${_ENV_}.yaml > $IOTEX_HOME/etc/genesis.yaml
+    curl -Ss --connect-timeout 10 \
+        --max-time 10 \
+        --retry 10 \
+        --retry-delay 0 \
+        --retry-max-time 40 \
+        https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/${version}/config_${_ENV_}.yaml > $IOTEX_HOME/etc/config.yaml
+
+    response=$?
+    if test "$response" != "0"; then
+        echo -e "${RED} Download of default configuration failed with: $response"
+        exit 1
+    fi
+
+    curl -Ss --connect-timeout 10 \
+        --max-time 10 \
+        --retry 10 \
+        --retry-delay 0 \
+        --retry-max-time 40 \
+        https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/${version}/genesis_${_ENV_}.yaml > $IOTEX_HOME/etc/genesis.yaml
+
+    response=$?
+    if test "$response" != "0"; then
+        echo -e "${RED} Download of genesis configuration failed with: $response"
+        exit 1
+    fi
     # https://raw.githubusercontent.com/iotexproject/iotex-bootstrap/v0.9.2/config_mainnet.yaml
 
     SED_IS_GNU=0