Skip to content

Commit 7decd0b

Browse files
kofoeddkjcesarmobile
authored andcommitted
fix(android): plugin retained events not being retained if listeners were empty (#2408)
1 parent cf2f746 commit 7decd0b

File tree

1 file changed

+2
-2
lines changed
  • android/capacitor/src/main/java/com/getcapacitor

1 file changed

+2
-2
lines changed

android/capacitor/src/main/java/com/getcapacitor/Plugin.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ public void pluginRequestPermission(String permission, int requestCode) {
300300
*/
301301
private void addEventListener(String eventName, PluginCall call) {
302302
List<PluginCall> listeners = eventListeners.get(eventName);
303-
if (listeners == null) {
303+
if (listeners == null || listeners.isEmpty()) {
304304
listeners = new ArrayList<PluginCall>();
305305
eventListeners.put(eventName, listeners);
306306

@@ -335,7 +335,7 @@ private void removeEventListener(String eventName, PluginCall call) {
335335
protected void notifyListeners(String eventName, JSObject data, boolean retainUntilConsumed) {
336336
Log.v(getLogTag(), "Notifying listeners for event " + eventName);
337337
List<PluginCall> listeners = eventListeners.get(eventName);
338-
if (listeners == null) {
338+
if (listeners == null || listeners.isEmpty()) {
339339
Log.d(getLogTag(), "No listeners found for event " + eventName);
340340
if (retainUntilConsumed) {
341341
retainedEventArguments.put(eventName, data);

0 commit comments

Comments
 (0)