correctly scale HEATING_CONTROL_HMIP.LEVEL

- closes #460
- closes #748
- closes #756

Author: foxriver76

README.md

@@ -160,7 +160,7 @@ To update all available images execute `npm run update-images`
 
 ### __WORK IN PROGRESS__
 * (foxriver76) added new images (closes #778, closes #873, closes #882)
-* (foxriver76) fix wrong paramsets (closes #617, closes #584, closes #539, closes #764)
+* (foxriver76) fix wrong paramsets (closes #617, closes #584, closes #539, closes #764, closes #460, closes #748, closes #756)
 * (foxriver76) fix wrong events (closes #872)
 
 ### 1.15.16 (2022-12-08)

build/lib/tools.js

@@ -114,12 +114,8 @@ export interface ListDevicesEntry {
 export type Daemon = 'CUxD' | 'virtual-devices' | 'rfd' | 'hs485d' | 'HMIP';
 
 export interface FixParamsetParams {
-    /** the parameter key e.g. LEVEL */
-    key: string;
-    /** the paramset */
+    /** the paramset, which will be fixed */
     paramObj: ParamsetObjectWithSpecial | ParamsetObject;
-    /** the object to fix */
-    obj: ioBroker.SettableStateObject;
     /** selected daemon type */
     daemon: Daemon;
 }

build/lib/tools.js.map

@@ -273,26 +273,31 @@ export function combineEPaperCommand(
  * @param params relevant parameters
  */
 export function fixParamset(params: FixParamsetParams): void {
-    const { key, obj, paramObj, daemon } = params;
+    const { paramObj, daemon } = params;
 
     // #346: it seems like if devices connect to a HMIP-HAP, RSSI_DEVICE shows 128, eq3 should fix this, but lets workaround
-    if (key === 'RSSI_DEVICE') {
-        obj.common.max = 128;
+    if (paramObj.ID === 'RSSI_DEVICE') {
+        paramObj.MAX = 128;
     }
 
     // #617, #584: for the codes there is often a value greater than max set, so we remove the max for now
     if (paramObj.CONTROL === 'MAINTENANCE.CODE_ID') {
-        delete obj.common.max;
+        paramObj.MAX = 9_999;
     }
 
     // # 539: while HMIP heating groups correctly have min 4.5 this is not the case for rfd somehow
     if (paramObj.CONTROL === 'HEATING_CONTROL.SETPOINT' && daemon === 'virtual-devices') {
-        obj.common.min = 4.5;
+        paramObj.MIN = 4.5;
     }
 
     // #764: HMIP heating groups active profile is declared with a max of 3 but 6 is the real max
     if (paramObj.CONTROL === 'HEATING_CONTROL_HMIP.ACTIVE_PROFILE' && daemon === 'virtual-devices') {
-        obj.common.max = 6;
+        paramObj.MAX = 6;
+    }
+
+    // #460 #748, #756: Heating control levels are displayed as UNIT: % with max of 1, but it should scale to 100
+    if (paramObj.CONTROL === 'HEATING_CONTROL_HMIP.LEVEL') {
+        paramObj.UNIT = '100%';
     }
 }