fix(ui): do not update bbox when changing models if model base has not changed

Author: psychedelicious

invokeai/frontend/web/src/app/store/middleware/listenerMiddleware/listeners/modelSelected.ts

@@ -4,6 +4,7 @@ import { bboxSyncedToOptimalDimension } from 'features/controlLayers/store/canva
 import { selectIsStaging } from 'features/controlLayers/store/canvasStagingAreaSlice';
 import { loraDeleted } from 'features/controlLayers/store/lorasSlice';
 import { modelChanged, vaeSelected } from 'features/controlLayers/store/paramsSlice';
+import { selectBboxModelBase } from 'features/controlLayers/store/selectors';
 import { modelSelected } from 'features/parameters/store/actions';
 import { zParameterModel } from 'features/parameters/types/parameterSchemas';
 import { toast } from 'features/toast/toast';
@@ -70,7 +71,8 @@ export const addModelSelectedListener = (startAppListening: AppStartListening) =
       }
 
       dispatch(modelChanged({ model: newModel, previousModel: state.params.model }));
-      if (!selectIsStaging(state)) {
+      const modelBase = selectBboxModelBase(state);
+      if (!selectIsStaging(state) && modelBase !== state.params.model?.base) {
         dispatch(bboxSyncedToOptimalDimension());
       }
     },

invokeai/frontend/web/src/app/store/middleware/listenerMiddleware/listeners/modelsLoaded.ts

@@ -3,12 +3,10 @@ import type { AppStartListening } from 'app/store/middleware/listenerMiddleware'
 import type { AppDispatch, RootState } from 'app/store/store';
 import type { SerializableObject } from 'common/types';
 import {
-  bboxSyncedToOptimalDimension,
   controlLayerModelChanged,
   referenceImageIPAdapterModelChanged,
   rgIPAdapterModelChanged,
 } from 'features/controlLayers/store/canvasSlice';
-import { selectIsStaging } from 'features/controlLayers/store/canvasStagingAreaSlice';
 import { loraDeleted } from 'features/controlLayers/store/lorasSlice';
 import {
   clipEmbedModelSelected,
@@ -20,6 +18,7 @@ import {
 } from 'features/controlLayers/store/paramsSlice';
 import { selectCanvasSlice } from 'features/controlLayers/store/selectors';
 import { getEntityIdentifier } from 'features/controlLayers/store/types';
+import { modelSelected } from 'features/parameters/store/actions';
 import { postProcessingModelChanged, upscaleModelChanged } from 'features/parameters/store/upscaleSlice';
 import {
   zParameterCLIPEmbedModel,
@@ -120,10 +119,7 @@ const handleMainModels: ModelHandler = (models, state, dispatch, log) => {
         { selectedMainModel, defaultModel },
         'No selected main model or selected main model is not available, selecting default model'
       );
-      dispatch(modelChanged({ model: zParameterModel.parse(defaultModel), previousModel: selectedMainModel }));
-      if (!selectIsStaging(state)) {
-        dispatch(bboxSyncedToOptimalDimension());
-      }
+      dispatch(modelSelected(defaultModel));
       return;
     }
   }
@@ -132,10 +128,7 @@ const handleMainModels: ModelHandler = (models, state, dispatch, log) => {
     { selectedMainModel, firstModel },
     'No selected main model or selected main model is not available, selecting first available model'
   );
-  dispatch(modelChanged({ model: zParameterModel.parse(firstModel), previousModel: selectedMainModel }));
-  if (!selectIsStaging(state)) {
-    dispatch(bboxSyncedToOptimalDimension());
-  }
+  dispatch(modelSelected(firstModel));
 };
 
 const handleUpscalingModels: ModelHandler = (models, state, dispatch, log) => {

invokeai/frontend/web/src/features/controlLayers/store/selectors.ts

@@ -338,6 +338,7 @@ export const selectAspectRatioValue = createSelector(selectCanvasSlice, (canvas)
 export const selectScaledSize = createSelector(selectBbox, (bbox) => bbox.scaledSize);
 export const selectScaleMethod = createSelector(selectBbox, (bbox) => bbox.scaleMethod);
 export const selectBboxRect = createSelector(selectBbox, (bbox) => bbox.rect);
+export const selectBboxModelBase = createSelector(selectBbox, (bbox) => bbox.modelBase);
 
 export const selectCanvasMetadata = createSelector(
   selectCanvasSlice,