Skip to content

Commit 068a924

Browse files
fix(app): App type def fix (#8365)
--------- Co-authored-by: Mike Hardy <github@mikehardy.net>
1 parent 4bd883f commit 068a924

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/app/lib/modular/index.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ export function deleteApp(app: FirebaseApp): Promise<void>;
1515
* Registers a library's name and version for platform logging purposes.
1616
* @param libraryKeyOrName - Library name or key.
1717
* @param version - Library version.
18-
* @param variant - Library variant.
18+
* @param variant - Library variant. Optional.
1919
* @returns Promise<void>
2020
*/
2121
export function registerVersion(
2222
libraryKeyOrName: string,
2323
version: string,
24-
variant: string | null,
24+
variant?: string,
2525
): Promise<void>;
2626

2727
/**

packages/app/lib/modular/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export function deleteApp(app) {
3131
* Registers a library's name and version for platform logging purposes.
3232
@param {string} libraryKeyOrName - library name or key.
3333
@param {string} version - library version.
34-
@param {string | null} variant - library variant.
34+
@param {string | undefined} variant - library variant. Optional.
3535
* @returns {Promise<void>}
3636
*/
3737
export function registerVersion(libraryKeyOrName, version, variant) {

0 commit comments

Comments
 (0)