fix(code): smells removed (lint updated)

Author: arnobl

package-lock.json

@@ -51,13 +51,13 @@
     "@typescript-eslint/parser": "8.8.0",
     "barrelsby": "2.8.1",
     "eslint": "8.57.0",
-    "@stylistic/eslint-plugin": "2.8.0",
+    "@stylistic/eslint-plugin": "2.9.0",
     "eslint-plugin-array-func": "4.0.0",
-    "eslint-plugin-import": "2.30.0",
+    "eslint-plugin-import": "2.31.0",
     "eslint-plugin-jest": "28.8.3",
-    "eslint-plugin-jsdoc": "50.3.1",
+    "eslint-plugin-jsdoc": "50.4.1",
     "eslint-plugin-tsdoc": "0.3.0",
-    "eslint-plugin-unicorn": "55.0.0",
+    "eslint-plugin-unicorn": "56.0.0",
     "husky": "9.0.11",
     "interacto-nono": "0.5.0",
     "jest": "29.7.0",

package.json

@@ -60,7 +60,7 @@ export class DwellSpringAnimation {
             }
         } else {
             clearInterval(this.interval);
-            this.interval = window.setInterval(() => {
+            this.interval = globalThis.window.setInterval(() => {
                 clearInterval(this.interval);
                 this.displaySpring = true;
                 this.positionSpring = {

src/impl/animation/DwellSpringAnimation.ts

@@ -68,7 +68,7 @@ export class TimeoutTransition extends TransitionBase<Event> {
                 return;
             }
 
-            this.timeoutThread = window.setTimeout(() => {
+            this.timeoutThread = globalThis.window.setTimeout(() => {
                 try {
                     this.timeouted = true;
                     this.src.fsm.onTimeout();

src/impl/fsm/TimeoutTransition.ts

@@ -20,7 +20,7 @@
  */
 export function remove<T>(array: Array<T>, elt: T): void {
     const index = array.indexOf(elt);
-    if (index > -1) {
+    if (index !== -1) {
         array.splice(index, 1);
     }
 }

src/impl/util/ArrayUtil.ts

@@ -23,7 +23,7 @@ describe("using a scroll data", () => {
         data = new ScrollDataImpl();
         evt = new UIEvent("mousedown");
 
-        const newWindow = {...window};
+        const newWindow = {...globalThis.window};
         Object.defineProperties(newWindow, {
             "scrollX": {
                 get(): number {
@@ -36,7 +36,7 @@ describe("using a scroll data", () => {
                 }
             }
         });
-        jest.spyOn(global, "window", "get")
+        jest.spyOn(globalThis.global, "window", "get")
             .mockReturnValue(newWindow);
     });
 

test/interaction/ScrollDataImpl.test.ts

@@ -57,7 +57,7 @@ export function createTouchEvent(type: "touchend" | "touchmove" | "touchstart",
     const clientXvalue = clientX ?? 0;
     const clientYvalue = clientY ?? 0;
     const evt = new TouchEvent(type, {
-        "view": window,
+        "view": globalThis.window,
         "bubbles": true,
         "cancelable": false,
         "detail": 1,
@@ -147,7 +147,7 @@ export function createMouseEvent(type: "auxclick" | "click" | "mousedown" | "mou
     const clientXvalue = clientX ?? 0;
     const clientYvalue = clientY ?? 0;
     return new MouseEvent(type, {
-        "view": window,
+        "view": globalThis.window,
         "bubbles": true,
         "cancelable": false,
         "detail": 1,
@@ -177,7 +177,7 @@ export function createWheelEvent(type: "wheel",
     const deltaYValue = deltaY ?? 0;
     const deltaZValue = deltaZ ?? 0;
     return new WheelEvent(type, {
-        "view": window,
+        "view": globalThis.window,
         "bubbles": true,
         "cancelable": false,
         "detail": 1,
@@ -202,7 +202,7 @@ export function createKeyEvent(type: "keydown" | "keyup", key = "", code = ""):
     return new KeyboardEvent(type, {
         "cancelable": false,
         "bubbles": true,
-        "view": window,
+        "view": globalThis.window,
         code,
         key,
         "repeat": false
@@ -214,7 +214,7 @@ export function createUIEvent(type: EventType): UIEvent {
         "detail": 0,
         "bubbles": true,
         "cancelable": false,
-        "view": window
+        "view": globalThis.window
     });
 }
 

test/interaction/StubEvents.ts

@@ -145,7 +145,7 @@ describe("using a logger", () => {
             "setRequestHeader": jest.fn()
         };
 
-        jest.spyOn(window, "XMLHttpRequest").mockImplementation(() => xhrMock as XMLHttpRequest);
+        jest.spyOn(globalThis.window, "XMLHttpRequest").mockImplementation(() => xhrMock as XMLHttpRequest);
 
         logger.writeConsole = false;
         logger.serverAddress = "localhost";
@@ -252,7 +252,7 @@ describe("using a logger", () => {
             "setRequestHeader": jest.fn()
         };
 
-        jest.spyOn(window, "XMLHttpRequest").mockImplementation(() => xhrMock as XMLHttpRequest);
+        jest.spyOn(globalThis.window, "XMLHttpRequest").mockImplementation(() => xhrMock as XMLHttpRequest);
         logger.writeConsole = false;
         logger.serverAddress = "yolo";
         logger.logBindingStart("foo3");