Skip to content
This repository was archived by the owner on Jan 29, 2025. It is now read-only.

Commit ebfff49

Browse files
killianmuldoonuniemimu
authored andcommitted
Add top level Makefile for PAS repo
A top level Makefile with targets that can be used on each lower level repo allows builds, tests and CI runs to be done across all subprojects in this directory. Co-authored-by: uniemimu <ukri.niemimuukko@intel.com>
1 parent 5a4774a commit ebfff49

File tree

5 files changed

+16
-7
lines changed

5 files changed

+16
-7
lines changed

Makefile

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
TOPTARGETS := all clean image build test
2+
3+
SUBDIRS := $(wildcard *-aware-scheduling/.)
4+
5+
$(TOPTARGETS): $(SUBDIRS)
6+
$(SUBDIRS):
7+
$(MAKE) -C $@ $(MAKECMDGOALS)
8+
9+
.PHONY: $(TOPTARGETS) $(SUBDIRS)

extender/scheduler.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//Package extender extender logic contains code to respond call from the http endpoint.
1+
//Package extender contains types and logic to respond to requests from a Kubernetes http scheduler extender.
22
package extender
33

44
import (
@@ -90,13 +90,13 @@ func checkSymLinks(filename string) error {
9090
return nil
9191
}
9292

93-
// StartServer starts the HTTP server needed for extender.
93+
// StartServer starts the HTTP server needed for the scheduler extender.
9494
// It registers the handlers and checks for existing telemetry policies.
9595
func (m Server) StartServer(port string, certFile string, keyFile string, caFile string, unsafe bool) {
9696
mx := http.NewServeMux()
9797
mx.HandleFunc("/", handlerWithMiddleware(errorHandler))
98-
mx.HandleFunc("/extender/prioritize", handlerWithMiddleware(m.Prioritize))
99-
mx.HandleFunc("/extender/filter", handlerWithMiddleware(m.Filter))
98+
mx.HandleFunc("/scheduler/prioritize", handlerWithMiddleware(m.Prioritize))
99+
mx.HandleFunc("/scheduler/filter", handlerWithMiddleware(m.Filter))
100100
var err error
101101
if unsafe {
102102
log.Printf("Extender Listening on HTTP %v", port)

telemetry-aware-scheduling/cmd/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ func main() {
3232
var kubeConfig, port, certFile, keyFile, caFile, syncPeriod string
3333
var unsafe bool
3434
flag.StringVar(&kubeConfig, "kubeConfig", "/root/.kube/config", "location of kubernetes config file")
35-
flag.StringVar(&port, "port", "9001", "port on which the extender extender will listen")
35+
flag.StringVar(&port, "port", "9001", "port on which the scheduler extender will listen")
3636
flag.StringVar(&certFile, "cert", "/etc/kubernetes/pki/ca.crt", "cert file extender will use for authentication")
3737
flag.StringVar(&keyFile, "key", "/etc/kubernetes/pki/ca.key", "key file extender will use for authentication")
3838
flag.StringVar(&caFile, "cacert", "/etc/kubernetes/pki/ca.crt", "ca file extender will use for authentication")

telemetry-aware-scheduling/pkg/telemetryscheduler/scheduler_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//Logic for the scheduler extender - including the server it starts and prioritize + filter methods - is implemented in this package.
1+
//Tests for the scheduler extender - including the server it starts and prioritize + filter methods - is implemented in this package.
22
package telemetryscheduler
33

44
import (

telemetry-aware-scheduling/pkg/telemetryscheduler/telemetryscheduler.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ func NewMetricsExtender(newCache cache.Reader) MetricsExtender {
3333
}
3434
}
3535

36-
//Prioritize manages all prioritize requests from the extender extender.
36+
//Prioritize manages all prioritize requests from the scheduler extender.
3737
//It decodes the package, checks its policy, and performs error checking.
3838
//It then calls the prioritize logic and writes a response to the scheduler.
3939
func (m MetricsExtender) Prioritize(w http.ResponseWriter, r *http.Request) {

0 commit comments

Comments
 (0)