You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[SYCL][Clang] Rename -Wno-libspirv-hip-cuda to -Wunsafe-libspirv-not-linked (#19053)
IMO there are a few problems with the current name:
- Its negative option form `-Wno-no-libspirv-hip-cuda` is very awkward.
- It is very specific about the HIP or CUDA backend, which does not
allow for future expansion to other backends, that might use libspirv.
- It's not descriptive: without the context of the error message, its
not at all clear what the warning is about.
// CHECK-DAG: warning: '-fno-sycl-libspirv' should not be used with target 'nvptx64-nvidia-cuda'; libspirv is required for correct behavior [-Wno-libspirv-hip-cuda]
5
-
// CHECK-DAG: warning: '-fno-sycl-libspirv' should not be used with target 'amdgcn-amd-amdhsa'; libspirv is required for correct behavior [-Wno-libspirv-hip-cuda]
4
+
// CHECK-DAG: warning: '-fno-sycl-libspirv' should not be used with target 'nvptx64-nvidia-cuda'; libspirv is required for correct behavior [-Wunsafe-libspirv-not-linked]
5
+
// CHECK-DAG: warning: '-fno-sycl-libspirv' should not be used with target 'amdgcn-amd-amdhsa'; libspirv is required for correct behavior [-Wunsafe-libspirv-not-linked]
0 commit comments